third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2722613003: [css-grid] "normal" alignment is "start" for replaced elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2722613003: [css-grid] "normal" alignment is "start" for replaced elements (Closed)

Patch Set: Applied suggested changes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 456e411cbfb3a0d7b3ddef0e74bf1e6bd0209937..519f49d51b47e747acbd8676dfe9dc1881eccc9b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2756,11 +2756,11 @@ bool LayoutBox::hasStretchedLogicalWidth() const {

const ComputedStyle* parentStyle = isAnonymous() ? cb->style() : nullptr;

if (cb->isHorizontalWritingMode() != isHorizontalWritingMode())

return style

- .resolvedAlignSelf(cb->selfAlignmentNormalBehavior(),

+ .resolvedAlignSelf(cb->selfAlignmentNormalBehavior(this),

parentStyle)

.position() == ItemPositionStretch;

return style

- .resolvedJustifySelf(cb->selfAlignmentNormalBehavior(),

+ .resolvedJustifySelf(cb->selfAlignmentNormalBehavior(this),

parentStyle)

.position() == ItemPositionStretch;

}