third_party/WebKit/Source/core/layout/LayoutBox.h - Issue 2722613003: [css-grid] "normal" alignment is "start" for replaced elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2722613003: [css-grid] "normal" alignment is "start" for replaced elements (Closed)

Patch Set: Applied suggested changes Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h

index 8bb840744a271fc962481aca33a32537d20fafdb..eda48c9efd564a5af8f583f2a8dbc59ba04660f5 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h

@@ -1381,7 +1381,9 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {

void styleDidChange(StyleDifference, const ComputedStyle* oldStyle) override;

void updateFromStyle() override;

- virtual ItemPosition selfAlignmentNormalBehavior() const {

+ virtual ItemPosition selfAlignmentNormalBehavior(

+ const LayoutBox* child = nullptr) const {

+ DCHECK(!child);

return ItemPositionStretch;

}