Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2722463004: Revert of Wait for popup animation using idling resource for ActionMode Tests (Closed)

Created:
3 years, 9 months ago by Fady Samuel
Modified:
3 years, 9 months ago
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Wait for popup animation using idling resource for ActionMode Tests (patchset #2 id:20001 of https://codereview.chromium.org/2686393002/ ) Reason for revert: Reverting due to org.chromium.android_webview.test.PopupWindowTest flake. https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/40348 Original issue's description: > Wait for popup animation using idling resource for ActionMode Tests > > BUG=675285 > > Review-Url: https://codereview.chromium.org/2686393002 > Cr-Commit-Position: refs/heads/master@{#453265} > Committed: https://chromium.googlesource.com/chromium/src/+/708f5678769916057460e6aaad3179e615ab079b TBR=yolandyan@chromium.org,mikecase@chromium.org,aluo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=675285 Review-Url: https://codereview.chromium.org/2722463004 Cr-Commit-Position: refs/heads/master@{#453329} Committed: https://chromium.googlesource.com/chromium/src/+/7c7c851f2d26771af4d3debf4e7aaa54d1c23353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -111 lines) Patch
M android_webview/tools/automated_ui_tests/javatests/src/org/chromium/webview_ui_test/test/ActionModeTest.java View 12 chunks +35 lines, -65 lines 0 comments Download
M android_webview/tools/automated_ui_tests/javatests/src/org/chromium/webview_ui_test/test/util/WebViewUiTestRule.java View 3 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Fady Samuel
Created Revert of Wait for popup animation using idling resource for ActionMode Tests
3 years, 9 months ago (2017-02-27 20:56:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722463004/1
3 years, 9 months ago (2017-02-27 20:57:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7c7c851f2d26771af4d3debf4e7aaa54d1c23353
3 years, 9 months ago (2017-02-27 20:58:49 UTC) #6
aluo
On 2017/02/27 20:58:49, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-02-27 23:34:51 UTC) #7
Fady Samuel
3 years, 9 months ago (2017-02-27 23:36:54 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2718243004/ by fsamuel@chromium.org.

The reason for reverting is: Unrelated failure..

Powered by Google App Engine
This is Rietveld 408576698