Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2686393002:
Wait for popup animation using idling resource for ActionMode Tests (Closed)
DescriptionWait for popup animation using idling resource for ActionMode Tests
BUG=675285
Review-Url: https://codereview.chromium.org/2686393002
Cr-Commit-Position: refs/heads/master@{#453265}
Committed: https://chromium.googlesource.com/chromium/src/+/708f5678769916057460e6aaad3179e615ab079b
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address Yoland's comments #Patch Set 3 : Fix failing select all test #
Messages
Total messages: 22 (14 generated)
aluo@chromium.org changed reviewers: + mikecase@chromium.org, yolandyan@chromium.org
ping
lgtm with nits https://codereview.chromium.org/2686393002/diff/1/android_webview/tools/autom... File android_webview/tools/automated_ui_tests/javatests/src/org/chromium/webview_ui_test/test/ActionModeTest.java (right): https://codereview.chromium.org/2686393002/diff/1/android_webview/tools/autom... android_webview/tools/automated_ui_tests/javatests/src/org/chromium/webview_ui_test/test/ActionModeTest.java:123: public void tearnDown() { tearDown https://codereview.chromium.org/2686393002/diff/1/android_webview/tools/autom... android_webview/tools/automated_ui_tests/javatests/src/org/chromium/webview_ui_test/test/ActionModeTest.java:252: * This view action clicks on center right of a view to select the last word Change the javadoc for this one
https://codereview.chromium.org/2686393002/diff/1/android_webview/tools/autom... File android_webview/tools/automated_ui_tests/javatests/src/org/chromium/webview_ui_test/test/ActionModeTest.java (right): https://codereview.chromium.org/2686393002/diff/1/android_webview/tools/autom... android_webview/tools/automated_ui_tests/javatests/src/org/chromium/webview_ui_test/test/ActionModeTest.java:123: public void tearnDown() { On 2017/02/24 23:45:36, the real yoland wrote: > tearDown Done. https://codereview.chromium.org/2686393002/diff/1/android_webview/tools/autom... android_webview/tools/automated_ui_tests/javatests/src/org/chromium/webview_ui_test/test/ActionModeTest.java:252: * This view action clicks on center right of a view to select the last word On 2017/02/24 23:45:36, the real yoland wrote: > Change the javadoc for this one Done.
The CQ bit was checked by aluo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by aluo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yolandyan@chromium.org Link to the patchset: https://codereview.chromium.org/2686393002/#ps20001 (title: "Address Yoland's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488218853080040,
"parent_rev": "e7dd2e9f08e32d46e37a9c37e586fd4742abb2df", "commit_rev":
"708f5678769916057460e6aaad3179e615ab079b"}
Message was sent while issue was closed.
Description was changed from ========== Wait for popup animation using idling resource for ActionMode Tests BUG=675285 ========== to ========== Wait for popup animation using idling resource for ActionMode Tests BUG=675285 Review-Url: https://codereview.chromium.org/2686393002 Cr-Commit-Position: refs/heads/master@{#453265} Committed: https://chromium.googlesource.com/chromium/src/+/708f5678769916057460e6aaad31... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/708f5678769916057460e6aaad31...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2722463004/ by fsamuel@chromium.org. The reason for reverting is: Reverting due to org.chromium.android_webview.test.PopupWindowTest flake. https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test....
Message was sent while issue was closed.
Description was changed from ========== Wait for popup animation using idling resource for ActionMode Tests BUG=675285 Review-Url: https://codereview.chromium.org/2686393002 Cr-Commit-Position: refs/heads/master@{#453265} Committed: https://chromium.googlesource.com/chromium/src/+/708f5678769916057460e6aaad31... ========== to ========== Wait for popup animation using idling resource for ActionMode Tests BUG=675285 Review-Url: https://codereview.chromium.org/2686393002 Cr-Commit-Position: refs/heads/master@{#453265} Committed: https://chromium.googlesource.com/chromium/src/+/708f5678769916057460e6aaad31... ==========
The CQ bit was checked by aluo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Just fixed the select all test, please review. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
