Ensure manifest exists in Port._wpt_manifest.

Ensure manifest exists in Port._wpt_manifest.

In this CL:
 - Move Manager._ensure_manifest to WPTManifest.ensure_manifest
 - Call it in Port._wpt_manifest

The purpose of this CL now is mainly to make rebaseline-cl etc. work again.

I'm not entirely sure that this is the absolute best solution; it might be theoretically possible that multiple Port objects could be created in separate processes, and that _wpt_manifest could be called on two at the same time, and both could start to try to copy the base manifest file at the same time. I don't *think* that this would happen now, since when actually running the tests, the manifest is always generated before gathering the list of tests (in Manager.run).

BUG=698294
Review-Url: https://codereview.chromium.org/2722243005
Cr-Commit-Position: refs/heads/master@{#454696}
Committed: https://chromium.googlesource.com/chromium/src/+/db5746f9a7e4afd9a91fd8fafc275f74035e6614

[qyearsley, 2017-03-03 18:53:24]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 18:53:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-03-03 19:00:28]

Description was changed from

==========
Ensure manifest exists in Port._wpt_manifest.

BUG=698294
==========

to

==========
Ensure manifest exists in Port._wpt_manifest.

In this CL:
 - Move Manager._ensure_manifest to WPTManifest.ensure_manifest
 - Call it in Port._wpt_manifest

The purpose of this CL now is mainly to make rebaseline-cl etc. work again.

I'm not entirely sure that this is the absolute best solution; it might be
theoretically possible that multiple Port objects could be created in separate
processes, and that _wpt_manifest could be called on two at the same time, and
both could start to try to copy the base manifest file at the same time. I don't
*think* that this would happen now, since when actually running the tests, the
manifest is always generated before gathering the list of tests (in
Manager.run).

BUG=698294
==========

[qyearsley, 2017-03-03 19:00:28]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[commit-bot: I haz the power, 2017-03-03 19:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 19:50:37]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2017-03-03 19:51:50]

Updated to call ensure_manifest in rebaseline_cl, not Port._wpt_manifest;
changed to log an error and try to continue in Port._manifest.

Does this seem OK?

[jeffcarp, 2017-03-03 20:02:07]

lgtm

[qyearsley, 2017-03-03 21:33:41]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-03-03 21:33:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 22:53:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488576821631180,
"parent_rev": "a7aae7e10e160c3ae98e54d15da269e463a59af7", "commit_rev":
"db5746f9a7e4afd9a91fd8fafc275f74035e6614"}

[commit-bot: I haz the power, 2017-03-03 22:54:27]

Description was changed from

==========
Ensure manifest exists in Port._wpt_manifest.

In this CL:
 - Move Manager._ensure_manifest to WPTManifest.ensure_manifest
 - Call it in Port._wpt_manifest

The purpose of this CL now is mainly to make rebaseline-cl etc. work again.

I'm not entirely sure that this is the absolute best solution; it might be
theoretically possible that multiple Port objects could be created in separate
processes, and that _wpt_manifest could be called on two at the same time, and
both could start to try to copy the base manifest file at the same time. I don't
*think* that this would happen now, since when actually running the tests, the
manifest is always generated before gathering the list of tests (in
Manager.run).

BUG=698294
==========

to

==========
Ensure manifest exists in Port._wpt_manifest.

In this CL:
 - Move Manager._ensure_manifest to WPTManifest.ensure_manifest
 - Call it in Port._wpt_manifest

The purpose of this CL now is mainly to make rebaseline-cl etc. work again.

I'm not entirely sure that this is the absolute best solution; it might be
theoretically possible that multiple Port objects could be created in separate
processes, and that _wpt_manifest could be called on two at the same time, and
both could start to try to copy the base manifest file at the same time. I don't
*think* that this would happen now, since when actually running the tests, the
manifest is always generated before gathering the list of tests (in
Manager.run).

BUG=698294

Review-Url: https://codereview.chromium.org/2722243005
Cr-Commit-Position: refs/heads/master@{#454696}
Committed:
https://chromium.googlesource.com/chromium/src/+/db5746f9a7e4afd9a91fd8fafc27...
==========

[commit-bot: I haz the power, 2017-03-03 22:54:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/db5746f9a7e4afd9a91fd8fafc27...