Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py

Issue 2722243005: Ensure manifest exists in Port._wpt_manifest. (Closed)
Patch Set: Call ensure manifest in rebaseline-cl Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
index 050a9acf73751ea6b2d289343fda5ed3aa368d79..7803e5b233037e7f6f652ae0d10d1e82ec362da9 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
@@ -178,55 +178,3 @@ class ManagerTest(unittest.TestCase):
if not port.host.filesystem.exists(dir_name):
deleted_dir_count = deleted_dir_count + 1
self.assertEqual(deleted_dir_count, 5)
-
- # Tests for protected methods - pylint: disable=protected-access
-
- def test_ensure_manifest_copies_new_manifest(self):
- host = MockHost()
- port = host.port_factory.get()
-
- manifest_path = '/mock-checkout/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json'
- self.assertFalse(port.host.filesystem.exists(manifest_path))
- manager = Manager(port, options=optparse.Values({'max_locked_shards': 1}), printer=FakePrinter())
- manager._ensure_manifest()
- self.assertTrue(port.host.filesystem.exists(manifest_path))
-
- webkit_base = '/mock-checkout/third_party/WebKit'
- self.assertEqual(
- port.host.executive.calls,
- [
- [
- 'python',
- webkit_base + '/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest',
- '--work',
- '--tests-root',
- webkit_base + '/LayoutTests/external/wpt',
- ]
- ]
- )
-
- def test_ensure_manifest_updates_manifest_if_it_exists(self):
- host = MockHost()
- port = host.port_factory.get('test-mac-mac10.10')
- manifest_path = '/mock-checkout/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json'
-
- host.filesystem.write_binary_file(manifest_path, '{}')
- self.assertTrue(port.host.filesystem.exists(manifest_path))
-
- manager = Manager(port, options=optparse.Values({'max_locked_shards': 1}), printer=FakePrinter())
- manager._ensure_manifest()
- self.assertTrue(port.host.filesystem.exists(manifest_path))
-
- webkit_base = '/mock-checkout/third_party/WebKit'
- self.assertEqual(
- port.host.executive.calls,
- [
- [
- 'python',
- webkit_base + '/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest',
- '--work',
- '--tests-root',
- webkit_base + '/LayoutTests/external/wpt',
- ]
- ]
- )

Powered by Google App Engine
This is Rietveld 408576698