Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java

Issue 2722233002: Fix two flaky media notification tests (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java
index 1e2d3bf6fcda0f505397e96971e8bf08a867010e..e33e20387c7749937fc537674f10a72d4d5962d0 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java
@@ -8,7 +8,6 @@ import android.support.test.filters.SmallTest;
import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils;
-import org.chromium.base.test.util.FlakyTest;
import org.chromium.blink.mojom.MediaSessionAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity;
@@ -29,7 +28,7 @@ import java.util.Set;
*/
public class NotificationActionsUpdatedTest extends ChromeActivityTestCaseBase<ChromeActivity> {
private static final int NOTIFICATION_ID = R.id.media_playback_notification;
- private static final String SIMPLE_PAGE_URL = "/content/test/data/simple_page.html";
+ private static final String TEST_PAGE_URL = "/content/test/data/media/session/title1.html";
private Tab mTab;
private EmbeddedTestServer mTestServer;
@@ -75,17 +74,16 @@ public class NotificationActionsUpdatedTest extends ChromeActivityTestCaseBase<C
assertActionsMatch(new HashSet<Integer>());
}
- @FlakyTest(message = "crbug.com/697453")
@SmallTest
public void testActionsPersistAfterSamePageNavigation() throws Throwable {
ensureTestServer();
- loadUrl(mTestServer.getURL(SIMPLE_PAGE_URL));
+ loadUrl(mTestServer.getURL(TEST_PAGE_URL));
simulateMediaSessionActionsChanged(mTab, buildActions());
simulateMediaSessionStateChanged(mTab, true, false);
assertActionsMatch(buildActions());
NotificationTestUtils.simulateSamePageNavigation(
- getInstrumentation(), mTab, mTestServer.getURL(SIMPLE_PAGE_URL));
+ getInstrumentation(), mTab, mTestServer.getURL(TEST_PAGE_URL));
assertActionsMatch(buildActions());
}
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698