Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2722053002: Merge M57: "Notify WASAPIAudioOutputStream users of rendering errors." (Closed)

Created:
3 years, 9 months ago by DaleCurtis
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge M57: "Notify WASAPIAudioOutputStream users of rendering errors." Upstream tracks error information and uses it to determine if a stream is acceptable for reuse. Rendering failures should cause the destruction of the stream, not allow reuse. BUG=695228 TEST=unplug/replug continues to work. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2720433002 Cr-Commit-Position: refs/heads/master@{#453005} (cherry picked from commit f1327bc594c83f73c44f83f1ac1b1ae63893487d) Review-Url: https://codereview.chromium.org/2722053002 . Cr-Commit-Position: refs/branch-heads/2987@{#727} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9d52d35cd4e7b0d23b87758138035db85430a598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
3 years, 9 months ago (2017-03-01 00:47:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9d52d35cd4e7b0d23b87758138035db85430a598.

Powered by Google App Engine
This is Rietveld 408576698