Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2720433002: Notify WASAPIAudioOutputStream users of rendering errors. (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify WASAPIAudioOutputStream users of rendering errors. Upstream tracks error information and uses it to determine if a stream is acceptable for reuse. Rendering failures should cause the destruction of the stream, not allow reuse. BUG=695228 TEST=unplug/replug continues to work. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2720433002 Cr-Commit-Position: refs/heads/master@{#453005} Committed: https://chromium.googlesource.com/chromium/src/+/f1327bc594c83f73c44f83f1ac1b1ae63893487d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
DaleCurtis
3 years, 10 months ago (2017-02-24 21:45:20 UTC) #3
DaleCurtis
cc:tommi in case he wants to weigh in.
3 years, 10 months ago (2017-02-24 21:45:42 UTC) #5
sandersd (OOO until July 31)
lgtm
3 years, 10 months ago (2017-02-24 22:01:29 UTC) #6
tommi (sloooow) - chröme
lgtm
3 years, 10 months ago (2017-02-24 22:49:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720433002/1
3 years, 10 months ago (2017-02-24 22:55:18 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 00:03:13 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1327bc594c83f73c44f83f1ac1b...

Powered by Google App Engine
This is Rietveld 408576698