Remove __attribute__((section (".bss"))) that doesn't work for PNaCl

Remove __attribute__((section (".bss"))) that doesn't work for PNaCl

It seems that __attribute__((section (".bss"))) has no sense for us anyway and PNaCl doesn't support it.

BUG=chromuim:302044
TEST=manual
R=eugenis@chromium.org, mseaborn@chromium.org

Committed: https://code.google.com/p/naclports/source/detail?r=1238

[Dmitry Polukhin, 2013-10-15 00:29:02]

PTAL

[Mark Seaborn, 2013-10-15 00:33:36]

https://codereview.chromium.org/27220005/diff/4001/libraries/glibc-compat/src...
says "Bad content. Try to upload again."

[Dmitry Polukhin, 2013-10-15 00:35:56]

Already tried twice with the same result :(
But udiff mode works https://codereview.chromium.org/27220005/patch/4001/5001

[Mark Seaborn, 2013-10-16 00:02:42]

LGTM

> Already tried twice with the same result :(
> But udiff mode works https://codereview.chromium.org/27220005/patch/4001/5001

OK.  Could you try again and tell Chrome infrastructure if it still doesn't
work?  Would be good to have the change displayed properly for the record, and
it's bad when our tools don't work.

https://codereview.chromium.org/27220005/diff/4001/libraries/glibc-compat/src...
File libraries/glibc-compat/src/res_libc.c (right):

https://codereview.chromium.org/27220005/diff/4001/libraries/glibc-compat/src...
libraries/glibc-compat/src/res_libc.c:149: +/* Removed
__attribute__((section(".bss"))) because PNaCl doesn't support
You might omit this commit (optional) -- commenting what used to be here seems
unnecessary.

https://codereview.chromium.org/27220005/diff/4001/libraries/glibc-compat/src...
libraries/glibc-compat/src/res_libc.c:150: +   this trick and trick with
removing common definition is not critical. */
Does this work when compiled with GCC given the following below:

compat_symbol (libc, _res, _res, GLIBC_2_0);

-- which presumably defines an alias?  Or is that line always disabled?

[dpolukhin, 2014-04-21 19:43:56]

Remove __attribute__((section (".bss"))) that doesn't work for PNaCl

It seems that __attribute__((section (".bss"))) has no sense for us anyway and
PNaCl doesn't support it.

BUG=chromuim:302044
TEST=manual

[Dmitry Polukhin, 2014-04-21 19:48:29]

Mark, please take another look. Sorry for very long delay with review. I return
back to this issue and it seems that there is no way to avoid this patch for
PNaCl toolchain.

And gcl upload still broken :(

https://codereview.chromium.org/27220005/diff/4001/libraries/glibc-compat/src...
File libraries/glibc-compat/src/res_libc.c (right):

https://codereview.chromium.org/27220005/diff/4001/libraries/glibc-compat/src...
libraries/glibc-compat/src/res_libc.c:150: +   this trick and trick with
removing common definition is not critical. */
On 2013/10/16 00:02:42, Mark Seaborn wrote:
> Does this work when compiled with GCC given the following below:
> 
> compat_symbol (libc, _res, _res, GLIBC_2_0);
> 
> -- which presumably defines an alias?  Or is that line always disabled?

Line compat_symbol (libc, _res, _res, GLIBC_2_0) is not compiled with
GCC/newlib. With GCC/glibc the whole library is not used.

[Dmitry Polukhin, 2014-04-21 23:47:25]

eugenis@, please take a look. It looks like Mark is OOO.

[eugenis, 2014-04-22 07:51:57]

LGTM

Could we remove this compat_symbol line then?

[Dmitry Polukhin, 2014-04-22 21:51:00]

On 2014/04/22 07:51:57, eugenis wrote:
> LGTM
> 
> Could we remove this compat_symbol line then?

Done.

[dpolukhin, 2014-04-22 22:00:13]

Committed patchset #5 manually as r1238 (tree was closed).