Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 27220005: Remove __attribute__((section (".bss"))) that doesn't work for PNaCl (Closed)

Created:
7 years, 2 months ago by dpolukhin
Modified:
6 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Remove __attribute__((section (".bss"))) that doesn't work for PNaCl It seems that __attribute__((section (".bss"))) has no sense for us anyway and PNaCl doesn't support it. BUG=chromuim:302044 TEST=manual R=eugenis@chromium.org, mseaborn@chromium.org Committed: https://code.google.com/p/naclports/source/detail?r=1238

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Remove __attribute__((section (".bss"))) that doesn't work for PNaCl #

Patch Set 4 : reupload #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M ports/glibc-compat/src/res_libc.c View 1 2 3 4 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Dmitry Polukhin
PTAL
7 years, 2 months ago (2013-10-15 00:29:02 UTC) #1
Mark Seaborn
https://codereview.chromium.org/27220005/diff/4001/libraries/glibc-compat/src/res_libc.c says "Bad content. Try to upload again."
7 years, 2 months ago (2013-10-15 00:33:36 UTC) #2
Dmitry Polukhin
Already tried twice with the same result :( But udiff mode works https://codereview.chromium.org/27220005/patch/4001/5001
7 years, 2 months ago (2013-10-15 00:35:56 UTC) #3
Mark Seaborn
LGTM > Already tried twice with the same result :( > But udiff mode works ...
7 years, 2 months ago (2013-10-16 00:02:42 UTC) #4
dpolukhin
Remove __attribute__((section (".bss"))) that doesn't work for PNaCl It seems that __attribute__((section (".bss"))) has no ...
6 years, 8 months ago (2014-04-21 19:43:56 UTC) #5
Dmitry Polukhin
Mark, please take another look. Sorry for very long delay with review. I return back ...
6 years, 8 months ago (2014-04-21 19:48:29 UTC) #6
Dmitry Polukhin
eugenis@, please take a look. It looks like Mark is OOO.
6 years, 8 months ago (2014-04-21 23:47:25 UTC) #7
eugenis
LGTM Could we remove this compat_symbol line then?
6 years, 8 months ago (2014-04-22 07:51:57 UTC) #8
Dmitry Polukhin
On 2014/04/22 07:51:57, eugenis wrote: > LGTM > > Could we remove this compat_symbol line ...
6 years, 8 months ago (2014-04-22 21:51:00 UTC) #9
dpolukhin
6 years, 8 months ago (2014-04-22 22:00:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #5 manually as r1238 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698