Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: ports/glibc-compat/src/res_libc.c

Issue 27220005: Remove __attribute__((section (".bss"))) that doesn't work for PNaCl (Closed) Base URL: http://naclports.googlecode.com/svn/trunk/src/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ports/glibc-compat/src/res_libc.c
===================================================================
--- ports/glibc-compat/src/res_libc.c (revision 1237)
+++ ports/glibc-compat/src/res_libc.c (working copy)
@@ -146,7 +146,9 @@
This differs from plain `struct __res_state _res;' in that it doesn't
create a common definition, but a plain symbol that resides in .bss,
which can have an alias. */
-struct __res_state _res __attribute__((section (".bss")));
+/* Removed __attribute__((section(".bss"))) because PNaCl doesn't support
+ this trick and trick with removing common definition is not critical. */
+struct __res_state _res /* __attribute__((section (".bss"))) */;
#define USE___THREAD 1
@@ -155,13 +157,6 @@
__thread struct __res_state *__resp = &_res;
#endif
-/* We declare this with compat_symbol so that it's not
- visible at link time. Programs must use the accessor functions. */
-#if defined HAVE_ELF && defined SHARED && defined DO_VERSIONING
-# include <shlib-compat.h>
-compat_symbol (libc, _res, _res, GLIBC_2_0);
-#endif
-
#include <shlib-compat.h>
#if SHLIB_COMPAT(libc, GLIBC_2_0, GLIBC_2_2)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698