Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: libraries/glibc-compat/src/res_libc.c

Issue 27220005: Remove __attribute__((section (".bss"))) that doesn't work for PNaCl (Closed) Base URL: http://naclports.googlecode.com/svn/trunk/src/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libraries/glibc-compat/src/res_libc.c
===================================================================
--- libraries/glibc-compat/src/res_libc.c (revision 917)
+++ libraries/glibc-compat/src/res_libc.c (working copy)
@@ -146,7 +146,9 @@
This differs from plain `struct __res_state _res;' in that it doesn't
create a common definition, but a plain symbol that resides in .bss,
which can have an alias. */
-struct __res_state _res __attribute__((section (".bss")));
+/* Removed __attribute__((section(".bss"))) because PNaCl doesn't support
Mark Seaborn 2013/10/16 00:02:42 You might omit this commit (optional) -- commentin
+ this trick and trick with removing common definition is not critical. */
Mark Seaborn 2013/10/16 00:02:42 Does this work when compiled with GCC given the fo
Dmitry Polukhin 2014/04/21 19:48:29 Line compat_symbol (libc, _res, _res, GLIBC_2_0) i
+struct __res_state _res;
#define USE___THREAD 1
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698