Fixed close button for retina displays in identity approval scope UI

Fixed close button for retina displays in identity approval scope UI

In the mean time, I've also renamed identityPrivate.getResources to
identityPrivate.getStrings to be more consistent with the fileBrowserPrivate,
wallpaperPrivate, bookmarkManagerPrivate and feedbackPrivate.

BUG=372318
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271366

[François Beaufort, 2014-05-14 08:46:09]

Hello, I've fixed a minor issue with the identity approval scope UI close button
on retina displays.

And while I was there, I've did some cleanup in the identityPrivate API.

xiyuan@chromium.org

  chrome/browser/resources/identity_scope_approval_dialog/manifest.json
 
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.css
 
chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js

asargent@chromium.org

  chrome/browser/extensions/api/identity_private/identity_private_api.h
  chrome/browser/extensions/api/identity_private/identity_private_api.cc

asvitkine@chromium.org

  extensions/browser/extension_function_histogram_value.h
  tools/metrics/histograms/histograms.xml

[François Beaufort, 2014-05-14 08:49:53]

Not sure first email was correctly sent to reviewers.

[xiyuan, 2014-05-14 15:40:44]

chrome/browser/resources/* LGTM

[François Beaufort, 2014-05-16 12:13:29]

(gentle ping)

[Alexei Svitkine (slow), 2014-05-16 13:06:33]

histograms lgtm

[asargent_no_longer_on_chrome, 2014-05-16 17:25:51]

lgtm (sorry for latency, somehow I missed seeing this in my inbox until today)

[François Beaufort, 2014-05-16 19:29:37]

The CQ bit was checked by beaufort.francois@gmail.com

[commit-bot: I haz the power, 2014-05-16 19:30:06]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/272173004/...

[commit-bot: I haz the power, 2014-05-17 06:19:17]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-17 06:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-17 06:23:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[François Beaufort, 2014-05-17 06:31:11]

On 2014/05/17 06:23:09, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

I'm not sure what to do next.
Could you help me? 

Here's the error:

** Presubmit Warnings **
The change starting at line 531 and ending at line 531 is *not* located
*exactly* at the end of the enum definition. Unless you are renaming an existing
entry, this is not a valid change, as new entries should *always* be added at
the end of the enum definition, right before the "  // Last entry:" entry.
  extensions/browser/extension_function_histogram_value.h(531):  
IDENTITYPRIVATE_GETSTRINGS,

***************
The file "extensions/browser/extension_function_histogram_value.h" contains the
definition of the ("enum HistogramValue {") enum which should be edited in
specific ways only - *** read the comments at the top of the header file ***.
There are changes to the file that may be incorrect and warrant manual
confirmation after review. Note that this presubmit script can not reliably
report the nature of all types of invalid changes, especially when the diffs are
complex. For example, an invalid deletion may be reported whereas the change
contains a valid rename.
***************

[François Beaufort, 2014-05-19 07:47:26]

The CQ bit was checked by beaufort.francois@gmail.com

[commit-bot: I haz the power, 2014-05-19 07:47:43]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/272173004/...

[commit-bot: I haz the power, 2014-05-19 07:51:17]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[François Beaufort, 2014-05-19 07:54:01]

The CQ bit was unchecked by beaufort.francois@gmail.com

[François Beaufort, 2014-05-19 07:54:02]

The CQ bit was checked by beaufort.francois@gmail.com

[commit-bot: I haz the power, 2014-05-19 07:54:24]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/272173004/...

[commit-bot: I haz the power, 2014-05-19 07:58:43]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-19 08:01:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 08:01:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[François Beaufort, 2014-05-19 08:08:36]

On 2014/05/19 08:01:31, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

With your approval, I'd like to submit this CL with NOTRY=true because
NOPRESUBMIT=true seems to not be enough.

[Alexei Svitkine (slow), 2014-05-19 12:29:46]

NOTRY=true sounds okay, given the presubmit is a false positive here

[François Beaufort, 2014-05-19 12:32:22]

The CQ bit was checked by beaufort.francois@gmail.com

[commit-bot: I haz the power, 2014-05-19 12:32:56]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/beaufort.francois@gmail.com/272173004/...

[commit-bot: I haz the power, 2014-05-19 12:33:54]

Change committed as 271366

[asargent_no_longer_on_chrome, 2014-05-19 17:25:09]

We should probably change this to make it an git cl upload warning instead
of a presubmit one - that way people will still get the notice but
submission through the CQ won't be blocked or need the NOTRY=true
workaround (which is a big hammer that might let open a hole for other
problems through accidentally).

Francois - would you mind logging a bug about this pointing to your CL, and
CC rpaquay@ who I think wrote this presubmit check?



On Fri, May 16, 2014 at 11:31 PM, <beaufort.francois@gmail.com> wrote:

> On 2014/05/17 06:23:09, I haz the power (commit-bot) wrote:
>
>> Try jobs failed on following builders:
>>    chromium_presubmit on tryserver.chromium
>>
>
> (http://build.chromium.org/p/tryserver.chromium/builders/
> chromium_presubmit/builds/68256)
>
> I'm not sure what to do next.
> Could you help me?
>
> Here's the error:
>
> ** Presubmit Warnings **
> The change starting at line 531 and ending at line 531 is *not* located
> *exactly* at the end of the enum definition. Unless you are renaming an
> existing
> entry, this is not a valid change, as new entries should *always* be added
> at
> the end of the enum definition, right before the "  // Last entry:" entry.
>   extensions/browser/extension_function_histogram_value.h(531):
> IDENTITYPRIVATE_GETSTRINGS,
>
> ***************
> The file "extensions/browser/extension_function_histogram_value.h"
> contains the
> definition of the ("enum HistogramValue {") enum which should be edited in
> specific ways only - *** read the comments at the top of the header file
> ***.
> There are changes to the file that may be incorrect and warrant manual
> confirmation after review. Note that this presubmit script can not reliably
> report the nature of all types of invalid changes, especially when the
> diffs are
> complex. For example, an invalid deletion may be reported whereas the
> change
> contains a valid rename.
> ***************
>
>
>
> https://codereview.chromium.org/272173004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[François Beaufort, 2014-05-20 10:46:03]

Done. 
http://crbug.com/375201