Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: chrome/browser/extensions/api/identity_private/identity_private_api.cc

Issue 272173004: Fixed close button for retina displays in identity approval scope UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity_private/identity_private_api.cc
diff --git a/chrome/browser/extensions/api/identity_private/identity_private_api.cc b/chrome/browser/extensions/api/identity_private/identity_private_api.cc
index 08254abfe6726e44e622fd4c169f998be3445cdc..5b8a1d49577b848ca2b5666919614f59b2a9b25b 100644
--- a/chrome/browser/extensions/api/identity_private/identity_private_api.cc
+++ b/chrome/browser/extensions/api/identity_private/identity_private_api.cc
@@ -8,30 +8,22 @@
#include "base/values.h"
#include "grit/generated_resources.h"
-#include "grit/ui_resources.h"
#include "ui/base/l10n/l10n_util.h"
-#include "ui/base/webui/web_ui_util.h"
namespace extensions {
-IdentityPrivateGetResourcesFunction::IdentityPrivateGetResourcesFunction() {}
+IdentityPrivateGetStringsFunction::IdentityPrivateGetStringsFunction() {}
-IdentityPrivateGetResourcesFunction::~IdentityPrivateGetResourcesFunction() {}
+IdentityPrivateGetStringsFunction::~IdentityPrivateGetStringsFunction() {}
-bool IdentityPrivateGetResourcesFunction::RunSync() {
- base::DictionaryValue* result = new base::DictionaryValue;
+bool IdentityPrivateGetStringsFunction::RunSync() {
+ base::DictionaryValue* dict = new base::DictionaryValue;
+ SetResult(dict);
- result->SetString("IDR_CLOSE_DIALOG",
- webui::GetBitmapDataUrlFromResource(IDR_CLOSE_DIALOG));
- result->SetString("IDR_CLOSE_DIALOG_H",
- webui::GetBitmapDataUrlFromResource(IDR_CLOSE_DIALOG_H));
- result->SetString("IDR_CLOSE_DIALOG_P",
- webui::GetBitmapDataUrlFromResource(IDR_CLOSE_DIALOG_P));
- result->SetString(
- "IDS_EXTENSION_PERMISSIONS_PROMPT_TITLE",
+ dict->SetString(
+ "window-title",
l10n_util::GetStringUTF16(IDS_EXTENSION_PERMISSIONS_PROMPT_TITLE));
- SetResult(result);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698