chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js - Issue 272173004: Fixed close button for retina displays in identity approval scope UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js

Issue 272173004: Fixed close button for retina displays in identity approval scope UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.css ('k') | chrome/common/extensions/api/identity_private.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js

diff --git a/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js b/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js

index 7c23d38a234e328d78dea5f3679154e412f09a93..b2e5feb1f6a4f858e9d47169a0ca61bada325e8f 100644

--- a/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js

+++ b/chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js

@@ -47,19 +47,8 @@ document.addEventListener('DOMContentLoaded', function() {

window.close();

};

- chrome.identityPrivate.getResources(function(resources) {

- var style = document.styleSheets[0];

- function insertRule(selector, url) {

- style.insertRule(selector + ' { background-image: url(' + url + '); }',

- style.cssRules.length);

- }

- insertRule('.titlebar-close-button', resources.IDR_CLOSE_DIALOG);

- insertRule('.titlebar-close-button:hover', resources.IDR_CLOSE_DIALOG_H);

- insertRule('.titlebar-close-button:active', resources.IDR_CLOSE_DIALOG_P);

- document.title = resources.IDS_EXTENSION_PERMISSIONS_PROMPT_TITLE;

+ chrome.identityPrivate.getStrings(function(strings) {

+ document.title = strings['window-title'];

});