Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2721693002: Revert of Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-blink_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (patchset #21 id:400001 of https://codereview.chromium.org/2626183003/ ) Reason for revert: Causing crashes in canary: https://crbug.com/696528, https://crbug.com/696577 Original issue's description: > Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. > > BUG=527190 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2626183003 > Cr-Commit-Position: refs/heads/master@{#453128} > Committed: https://chromium.googlesource.com/chromium/src/+/4a40a757e7029a3f59b12543cbf617eceb15f7f0 TBR=haraken@chromium.org,yukishiino@chromium.org,jochen@chromium.org,lfg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527190 Review-Url: https://codereview.chromium.org/2721693002 Cr-Commit-Position: refs/heads/master@{#453290} Committed: https://chromium.googlesource.com/chromium/src/+/048c85fa7f4b8251aa4af20d108a149b5e6993fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -324 lines) Patch
M components/guest_view/renderer/guest_view_request.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.h View 3 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp View 4 chunks +5 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp View 4 chunks +61 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.h View 3 chunks +22 lines, -108 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 4 chunks +110 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl View 2 chunks +14 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 4 chunks +28 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 4 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrame.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
Created Revert of Switch RemoteWindowProxy to use v8::Context::NewRemoteContext.
3 years, 9 months ago (2017-02-27 19:21:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721693002/1
3 years, 9 months ago (2017-02-27 19:22:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/048c85fa7f4b8251aa4af20d108a149b5e6993fc
3 years, 9 months ago (2017-02-27 19:23:52 UTC) #6
haraken
LGTM
3 years, 9 months ago (2017-02-27 23:39:37 UTC) #7
Yuki
3 years, 9 months ago (2017-03-01 08:43:07 UTC) #8
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698