Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2721623002: Let parser handle factory modifiers. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Handle factory modifiers correctly in dart2js. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -28 lines) Patch
M pkg/compiler/lib/src/parser/node_listener.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/verifier.dart View 2 chunks +46 lines, -2 lines 2 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +11 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/bootstrap_test.dart View 2 chunks +10 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
ahe
3 years, 9 months ago (2017-02-27 15:41:50 UTC) #2
ahe
Uploaded a new patch set as I had to keep the old code in dart2js ...
3 years, 9 months ago (2017-02-27 17:38:20 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/2721623002/diff/20001/pkg/front_end/lib/src/fasta/kernel/verifier.dart File pkg/front_end/lib/src/fasta/kernel/verifier.dart (right): https://codereview.chromium.org/2721623002/diff/20001/pkg/front_end/lib/src/fasta/kernel/verifier.dart#newcode44 pkg/front_end/lib/src/fasta/kernel/verifier.dart:44: problem(TreeNode node, String details) { No use of ...
3 years, 9 months ago (2017-02-28 13:36:39 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/2721623002/diff/20001/pkg/front_end/lib/src/fasta/kernel/verifier.dart File pkg/front_end/lib/src/fasta/kernel/verifier.dart (right): https://codereview.chromium.org/2721623002/diff/20001/pkg/front_end/lib/src/fasta/kernel/verifier.dart#newcode44 pkg/front_end/lib/src/fasta/kernel/verifier.dart:44: problem(TreeNode node, String details) { On ...
3 years, 9 months ago (2017-02-28 13:46:25 UTC) #5
ahe
3 years, 9 months ago (2017-03-01 10:38:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bb72d5e8a0ce9dae9ebf6130987d3dae9aa6b796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698