Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: pkg/front_end/lib/src/fasta/source/source_library_builder.dart

Issue 2721623002: Let parser handle factory modifiers. (Closed)
Patch Set: Handle factory modifiers correctly in dart2js. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.source_library_builder; 5 library fasta.source_library_builder;
6 6
7 import 'package:kernel/ast.dart' show 7 import 'package:kernel/ast.dart' show
8 AsyncMarker, 8 AsyncMarker,
9 ProcedureKind; 9 ProcedureKind;
10 10
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 {bool isTopLevel}); 185 {bool isTopLevel});
186 186
187 void addEnum(List<MetadataBuilder> metadata, String name, 187 void addEnum(List<MetadataBuilder> metadata, String name,
188 List<String> constants, int charOffset); 188 List<String> constants, int charOffset);
189 189
190 void addFunctionTypeAlias(List<MetadataBuilder> metadata, 190 void addFunctionTypeAlias(List<MetadataBuilder> metadata,
191 T returnType, String name, 191 T returnType, String name,
192 List<TypeVariableBuilder> typeVariables, 192 List<TypeVariableBuilder> typeVariables,
193 List<FormalParameterBuilder> formals, int charOffset); 193 List<FormalParameterBuilder> formals, int charOffset);
194 194
195 void addFactoryMethod(List<MetadataBuilder> metadata, 195 void addFactoryMethod(List<MetadataBuilder> metadata, int modifiers,
196 ConstructorReferenceBuilder name, List<FormalParameterBuilder> formals, 196 ConstructorReferenceBuilder name, List<FormalParameterBuilder> formals,
197 AsyncMarker asyncModifier, ConstructorReferenceBuilder redirectionTarget, 197 AsyncMarker asyncModifier, ConstructorReferenceBuilder redirectionTarget,
198 int charOffset, String nativeMethodName); 198 int charOffset, String nativeMethodName);
199 199
200 FormalParameterBuilder addFormalParameter( 200 FormalParameterBuilder addFormalParameter(
201 List<MetadataBuilder> metadata, int modifiers, 201 List<MetadataBuilder> metadata, int modifiers,
202 T type, String name, bool hasThis, int charOffset); 202 T type, String name, bool hasThis, int charOffset);
203 203
204 TypeVariableBuilder addTypeVariable(String name, T bound, int charOffset); 204 TypeVariableBuilder addTypeVariable(String name, T bound, int charOffset);
205 205
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 } 472 }
473 473
474 /// Called to register [procedure] as a factory whose types are collected in 474 /// Called to register [procedure] as a factory whose types are collected in
475 /// [factoryDeclaration]. Later, once the class has been built, we can 475 /// [factoryDeclaration]. Later, once the class has been built, we can
476 /// synthesize type variables on the factory matching the class'. 476 /// synthesize type variables on the factory matching the class'.
477 void addFactoryDeclaration( 477 void addFactoryDeclaration(
478 ProcedureBuilder procedure, DeclarationBuilder<T> factoryDeclaration) { 478 ProcedureBuilder procedure, DeclarationBuilder<T> factoryDeclaration) {
479 factoryDeclarations[procedure] = factoryDeclaration; 479 factoryDeclarations[procedure] = factoryDeclaration;
480 } 480 }
481 } 481 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698