pkg/compiler/lib/src/parser/node_listener.dart - Issue 2721623002: Let parser handle factory modifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/parser/node_listener.dart

Issue 2721623002: Let parser handle factory modifiers. (Closed)

Patch Set: Handle factory modifiers correctly in dart2js. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/parser/node_listener.dart

diff --git a/pkg/compiler/lib/src/parser/node_listener.dart b/pkg/compiler/lib/src/parser/node_listener.dart

index 55a698ea95396910272d399cb5068145434896b8..f427fd599bc87c66835cf9c414f9647d5008d0ef 100644

--- a/pkg/compiler/lib/src/parser/node_listener.dart

+++ b/pkg/compiler/lib/src/parser/node_listener.dart

@@ -864,6 +864,7 @@ class NodeListener extends ElementListener {

AsyncModifier asyncModifier = popNode();

NodeList formals = popNode();

Node name = popNode();

+ popNode(); // Discard modifiers. They're recomputed below.

// TODO(ahe): Move this parsing to the parser.

int modifierCount = 0;