Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2721603005: Convert unnecessary ContextLifecycleObservers into ContextClients. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
haraken, dcheng
CC:
chromium-reviews, tzik, blink-reviews-css, nhiroki, dglazkov+blink, apavlov+blink_chromium.org, cmumford, darktears, blink-reviews, jsbell+idb_chromium.org, kinuko+fileapi, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert unnecessary ContextLifecycleObservers into ContextClients. Convert remaining types that do not make use of |contextDestroyed()| overriding, making them be context clients instead. R=dcheng,haraken BUG=610176 Review-Url: https://codereview.chromium.org/2721603005 Cr-Commit-Position: refs/heads/master@{#453574} Committed: https://chromium.googlesource.com/chromium/src/+/78c60265e580b80470359beeede8e05dd908852d

Patch Set 1 #

Patch Set 2 : normalize trace method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M third_party/WebKit/Source/core/css/FontFace.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
sof
please take a look.
3 years, 9 months ago (2017-02-28 10:01:59 UTC) #8
dcheng
lgtm
3 years, 9 months ago (2017-02-28 10:03:01 UTC) #9
haraken
LGTM
3 years, 9 months ago (2017-02-28 11:11:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721603005/20001
3 years, 9 months ago (2017-02-28 11:39:20 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 12:20:47 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/78c60265e580b80470359beeede8...

Powered by Google App Engine
This is Rietveld 408576698