Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp

Issue 2721603005: Convert unnecessary ContextLifecycleObservers into ContextClients. (Closed)
Patch Set: normalize trace method Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
index 22cc3dbbf01b8d483f6f55781a2c2ec4f6e8191b..f9ce3ff1e17d25ebedafdbfd8509acb88fad5db4 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
@@ -108,7 +108,7 @@ IDBTransaction::IDBTransaction(ExecutionContext* executionContext,
int64_t id,
const HashSet<String>& scope,
IDBDatabase* db)
- : ContextLifecycleObserver(executionContext),
+ : ContextClient(executionContext),
m_id(id),
m_database(db),
m_mode(WebIDBTransactionModeReadOnly),
@@ -125,7 +125,7 @@ IDBTransaction::IDBTransaction(ScriptState* scriptState,
const HashSet<String>& scope,
WebIDBTransactionMode mode,
IDBDatabase* db)
- : ContextLifecycleObserver(scriptState->getExecutionContext()),
+ : ContextClient(scriptState->getExecutionContext()),
m_id(id),
m_database(db),
m_mode(mode),
@@ -149,7 +149,7 @@ IDBTransaction::IDBTransaction(ExecutionContext* executionContext,
IDBDatabase* db,
IDBOpenDBRequest* openDBRequest,
const IDBDatabaseMetadata& oldMetadata)
- : ContextLifecycleObserver(executionContext),
+ : ContextClient(executionContext),
m_id(id),
m_database(db),
m_openDBRequest(openDBRequest),
@@ -177,7 +177,7 @@ DEFINE_TRACE(IDBTransaction) {
visitor->trace(m_oldStoreMetadata);
visitor->trace(m_deletedIndexes);
EventTargetWithInlineData::trace(visitor);
- ContextLifecycleObserver::trace(visitor);
+ ContextClient::trace(visitor);
}
void IDBTransaction::setError(DOMException* error) {
@@ -479,7 +479,7 @@ const AtomicString& IDBTransaction::interfaceName() const {
}
ExecutionContext* IDBTransaction::getExecutionContext() const {
- return ContextLifecycleObserver::getExecutionContext();
+ return ContextClient::getExecutionContext();
}
DispatchEventResult IDBTransaction::dispatchEventInternal(Event* event) {

Powered by Google App Engine
This is Rietveld 408576698