Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2721563003: DevTools: add CSS/JS type indication to coverage view (Closed)

Created:
3 years, 9 months ago by caseq
Modified:
3 years, 9 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add CSS/JS type indication to coverage view Review-Url: https://codereview.chromium.org/2721563003 Cr-Commit-Position: refs/heads/master@{#453753} Committed: https://chromium.googlesource.com/chromium/src/+/f67c3f27ee912093f7110cb33f33ff7f1a144371

Patch Set 1 : DevTools: add CSS/JS type indication to coverage view #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -38 lines) Patch
M third_party/WebKit/LayoutTests/inspector/coverage/coverage-view.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/coverage/coverage-view-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js View 4 chunks +20 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js View 4 chunks +36 lines, -34 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
caseq
3 years, 9 months ago (2017-02-28 00:40:21 UTC) #2
alph
lgtm https://codereview.chromium.org/2721563003/diff/20001/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js File third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js (right): https://codereview.chromium.org/2721563003/diff/20001/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js#newcode214 third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js:214: rulesByStyleSheet.entries(), entry => Coverage.CoverageView._coverageInfoForText( nit: ([header, ranges]) => ...
3 years, 9 months ago (2017-02-28 01:10:38 UTC) #4
caseq
On 2017/02/28 01:10:38, alph wrote: > lgtm > > https://codereview.chromium.org/2721563003/diff/20001/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js > File third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js > (right): ...
3 years, 9 months ago (2017-02-28 02:05:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721563003/20001
3 years, 9 months ago (2017-02-28 20:29:58 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:55:27 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f67c3f27ee912093f7110cb33f33...

Powered by Google App Engine
This is Rietveld 408576698