Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js

Issue 2721563003: DevTools: add CSS/JS type indication to coverage view (Closed)
Patch Set: DevTools: add CSS/JS type indication to coverage view Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
index 330fa2d70a34ea3e7c6b5b1be34d7e6403368981..abc86f261e406d58bad8da64b375de810435094a 100644
--- a/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
+++ b/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
@@ -15,7 +15,7 @@ Coverage.CoverageListView = class extends UI.VBox {
sortable: true,
align: DataGrid.DataGrid.Align.Right
},
- {
+ {id: 'type', title: Common.UIString('Type'), width: '30px', fixedWidth: true, sortable: true}, {
id: 'unusedSize',
title: Common.UIString('Unused Bytes'),
width: '60px',
@@ -91,6 +91,9 @@ Coverage.CoverageListView = class extends UI.VBox {
case 'url':
sortFunction = compareURL;
break;
+ case 'type':
+ sortFunction = compareNumericField.bind(null, 'type');
+ break;
case 'size':
sortFunction = compareNumericField.bind(null, 'size');
break;
@@ -129,6 +132,18 @@ Coverage.CoverageListView = class extends UI.VBox {
return nodeA._coverageInfo[fieldName] - nodeB._coverageInfo[fieldName];
}
}
+
+ /**
+ * @param {!Coverage.CoverageType} type
+ */
+ static _typeToString(type) {
+ var types = [];
+ if (type & Coverage.CoverageType.CSS)
+ types.push(Common.UIString('CSS'));
+ if (type & Coverage.CoverageType.JavaScript)
+ types.push(Common.UIString('JS'));
+ return types.join('+');
+ }
};
Coverage.CoverageListView.GridNode = class extends DataGrid.SortableDataGridNode {
@@ -152,6 +167,10 @@ Coverage.CoverageListView.GridNode = class extends DataGrid.SortableDataGridNode
switch (columnId) {
case 'url':
cell.textContent = this._coverageInfo.url;
+ cell.title = this._coverageInfo.url;
+ break;
+ case 'type':
+ cell.textContent = Coverage.CoverageListView._typeToString(this._coverageInfo.type);
break;
case 'size':
cell.classList.add('numeric-column');

Powered by Google App Engine
This is Rietveld 408576698