chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm - Issue 2721553002: Make web_app::ShortcutInfo RefCountedThreadSafe (1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm

Issue 2721553002: Make web_app::ShortcutInfo RefCountedThreadSafe (1) (Closed)

Patch Set: TestBrowserThreadBundle for mac test fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm b/chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm

index a46a263a568158c5c33a1e7da0a77556e18700f3..2a74510f7cba219ac7d148b98924d46b0949dccd 100644

--- a/chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm

+++ b/chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm

@@ -62,7 +62,7 @@ void CreateAppShortcutInfoLoaded(

Profile* profile,

const extensions::Extension* app,

const base::Callback<void(bool)>& close_callback,

- std::unique_ptr<web_app::ShortcutInfo> shortcut_info) {

+ scoped_refptr<web_app::ShortcutInfo> shortcut_info) {

base::scoped_nsobject<NSAlert> alert([[NSAlert alloc] init]);

NSButton* continue_button = [alert