Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.h

Issue 2721553002: Make web_app::ShortcutInfo RefCountedThreadSafe (1) (Closed)
Patch Set: TestBrowserThreadBundle for mac test fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/create_application_shortcut_view.h
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.h b/chrome/browser/ui/views/create_application_shortcut_view.h
index 07d45c12167426baff53c24602f1be7c7305e0d6..d58d2203a0c00b4a5edd449d1bedbc7f07168f08 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.h
+++ b/chrome/browser/ui/views/create_application_shortcut_view.h
@@ -85,7 +85,7 @@ class CreateApplicationShortcutView : public views::DialogDelegateView,
views::Checkbox* quick_launch_check_box_;
// Target shortcut and file handler info.
- std::unique_ptr<web_app::ShortcutInfo> shortcut_info_;
+ scoped_refptr<web_app::ShortcutInfo> shortcut_info_;
// If false, the shortcut will be created in the root level of the Start Menu.
bool create_in_chrome_apps_subdir_;
@@ -142,7 +142,7 @@ class CreateChromeApplicationShortcutView
private:
// Called when the app's ShortcutInfo (with icon) is loaded.
- void OnAppInfoLoaded(std::unique_ptr<web_app::ShortcutInfo> shortcut_info);
+ void OnAppInfoLoaded(scoped_refptr<web_app::ShortcutInfo> shortcut_info);
base::Callback<void(bool)> close_callback_;

Powered by Google App Engine
This is Rietveld 408576698