Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

Issue 2721553002: Make web_app::ShortcutInfo RefCountedThreadSafe (1) (Closed)
Patch Set: TestBrowserThreadBundle for mac test fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
diff --git a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
index 951fda233651269df8628e931b3e12af1da2d766..3cdbde16aebe1df1baf2f4af0cbd8eebe16a1823 100644
--- a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
+++ b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
@@ -219,7 +219,7 @@ bool HasAppShimHost(Profile* profile, const std::string& app_id) {
base::FilePath GetAppShimPath(Profile* profile,
const extensions::Extension* app) {
// Use a WebAppShortcutCreator to get the path.
- std::unique_ptr<web_app::ShortcutInfo> shortcut_info =
+ scoped_refptr<web_app::ShortcutInfo> shortcut_info =
web_app::ShortcutInfoForExtensionAndProfile(app, profile);
web_app::WebAppShortcutCreator shortcut_creator(
web_app::GetWebAppDataDirectory(profile->GetPath(), app->id(), GURL()),
@@ -550,7 +550,7 @@ IN_PROC_BROWSER_TEST_F(AppShimInteractiveTest, MAYBE_RebuildShim) {
const extensions::Extension* app = InstallPlatformApp("minimal");
// Use WebAppShortcutCreator to create a 64 bit shim.
- std::unique_ptr<web_app::ShortcutInfo> shortcut_info =
+ scoped_refptr<web_app::ShortcutInfo> shortcut_info =
web_app::ShortcutInfoForExtensionAndProfile(app, profile());
web_app::WebAppShortcutCreator shortcut_creator(
web_app::GetWebAppDataDirectory(profile()->GetPath(), app->id(), GURL()),
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/create_application_shortcut_cocoa.mm » ('j') | chrome/browser/web_applications/web_app.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698