Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(266)

Issue 2721543002: SharedWorker: Factor out WorkerReportingProxy impl from WebSharedWorkerImpl (Closed)

Created:
9 months, 2 weeks ago by nhiroki
Modified:
9 months, 2 weeks ago
Reviewers:
kinuko, haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SharedWorker: Factor out WorkerReportingProxy impl from WebSharedWorkerImpl WebSharedWorkerImpl is a heavily threaded class. Some methods are called on the main thread, while others are called on a worker thread. This often confuses my head... This CL factors out a part of WebSharedWorkerImpl that implement WorkerReportingProxy and are called on a worker thread into WebSharedWorkerReportingProxyImpl. Even with this cleanup, some methods called on a worker thread still remain in WebSharedWorkerImpl, but this would somewhat mitigate the situation and make threading boundary clearer. BUG=673711 Review-Url: https://codereview.chromium.org/2721543002 Cr-Commit-Position: refs/heads/master@{#453499} Committed: https://chromium.googlesource.com/chromium/src/+/0decaefae68c308e45aad3b3fbda9c5b9a6793a8

Patch Set 1 #

Patch Set 2 : fix compile failures on win bots #

Total comments: 2

Patch Set 3 : address review comments #

Patch Set 4 : fix typo #

Patch Set 5 : tweak header comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -96 lines) Patch
M third_party/WebKit/Source/web/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 2 3 4 6 chunks +14 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 2 3 18 chunks +36 lines, -64 lines 0 comments Download
A third_party/WebKit/Source/web/WebSharedWorkerReportingProxyImpl.h View 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/WebSharedWorkerReportingProxyImpl.cpp View 1 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (25 generated)
nhiroki
PTAL, thanks!
9 months, 2 weeks ago (2017-02-27 09:13:09 UTC) #10
kinuko
lgtm https://codereview.chromium.org/2721543002/diff/40001/third_party/WebKit/Source/web/WebSharedWorkerImpl.h File third_party/WebKit/Source/web/WebSharedWorkerImpl.h (right): https://codereview.chromium.org/2721543002/diff/40001/third_party/WebKit/Source/web/WebSharedWorkerImpl.h#newcode134 third_party/WebKit/Source/web/WebSharedWorkerImpl.h:134: // postTaskToLoader() and getLoaderExecutionContext() can be called from ...
9 months, 2 weeks ago (2017-02-28 00:19:16 UTC) #13
nhiroki
Thank you! https://codereview.chromium.org/2721543002/diff/40001/third_party/WebKit/Source/web/WebSharedWorkerImpl.h File third_party/WebKit/Source/web/WebSharedWorkerImpl.h (right): https://codereview.chromium.org/2721543002/diff/40001/third_party/WebKit/Source/web/WebSharedWorkerImpl.h#newcode134 third_party/WebKit/Source/web/WebSharedWorkerImpl.h:134: // postTaskToLoader() and getLoaderExecutionContext() can be called ...
9 months, 2 weeks ago (2017-02-28 01:09:23 UTC) #14
nhiroki
+haraken, can you review this as an owner of web/? Thanks!
9 months, 2 weeks ago (2017-02-28 01:11:21 UTC) #16
haraken
LGTM
9 months, 2 weeks ago (2017-02-28 02:36:00 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721543002/100001
9 months, 2 weeks ago (2017-02-28 04:10:23 UTC) #29
commit-bot: I haz the power
9 months, 2 weeks ago (2017-02-28 04:48:22 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/0decaefae68c308e45aad3b3fbda...

Powered by Google App Engine
This is Rietveld 0eb02b776