SharedWorker: Factor out WorkerReportingProxy impl from WebSharedWorkerImpl

SharedWorker: Factor out WorkerReportingProxy impl from WebSharedWorkerImpl

WebSharedWorkerImpl is a heavily threaded class. Some methods are called on the
main thread, while others are called on a worker thread. This often confuses my
head...

This CL factors out a part of WebSharedWorkerImpl that implement
WorkerReportingProxy and are called on a worker thread into
WebSharedWorkerReportingProxyImpl. Even with this cleanup, some methods called
on a worker thread still remain in WebSharedWorkerImpl, but this would somewhat
mitigate the situation and make threading boundary clearer.

BUG=673711
Review-Url: https://codereview.chromium.org/2721543002
Cr-Commit-Position: refs/heads/master@{#453499}
Committed: https://chromium.googlesource.com/chromium/src/+/0decaefae68c308e45aad3b3fbda9c5b9a6793a8

[nhiroki, 2017-02-27 07:28:50]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 07:29:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-02-27 07:32:20]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-27 08:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 08:03:23]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[nhiroki, 2017-02-27 08:36:54]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 08:37:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-02-27 09:12:44]

Description was changed from

==========
SharedWorker: Factor out WorkerReportingProxy impl from WebSharedWorkerImpl

WebSharedWorkerImpl is a heavily threaded class. Some methods are called on the
main thread, while others are called on a worker thread. This often confuses my
head...

This CL factors out a part of WebSharedWorkerImpl that implement
WorkerReportingProxy and are called on a worker thread into
WebSharedWorkerReportingProxyImpl. Even with this cleanup, some methods called
on a worker thread still remain in WebSharedWorkerImpl, but this would somewhat
mitigate the situation and make threading boundary clearer.

BUG=673711
==========

to

==========
SharedWorker: Factor out WorkerReportingProxy impl from WebSharedWorkerImpl

WebSharedWorkerImpl is a heavily threaded class. Some methods are called on the
main thread, while others are called on a worker thread. This often confuses my
head...

This CL factors out a part of WebSharedWorkerImpl that implement
WorkerReportingProxy and are called on a worker thread into
WebSharedWorkerReportingProxyImpl. Even with this cleanup, some methods called
on a worker thread still remain in WebSharedWorkerImpl, but this would somewhat
mitigate the situation and make threading boundary clearer.

BUG=673711
==========

[nhiroki, 2017-02-27 09:12:44]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org

[nhiroki, 2017-02-27 09:13:09]

PTAL, thanks!

[commit-bot: I haz the power, 2017-02-27 10:40:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 10:40:04]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-02-28 00:19:16]

lgtm

https://codereview.chromium.org/2721543002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.h (right):

https://codereview.chromium.org/2721543002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebSharedWorkerImpl.h:134: // postTaskToLoader()
and getLoaderExecutionContext() can be called from a
getLoaderExecutionContext must be called on the main thread.

postTaskToLoader must be called from the worker thread, so let's also change
'can be' -> 'must be'

[nhiroki, 2017-02-28 01:09:23]

Thank you!

https://codereview.chromium.org/2721543002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.h (right):

https://codereview.chromium.org/2721543002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebSharedWorkerImpl.h:134: // postTaskToLoader()
and getLoaderExecutionContext() can be called from a
On 2017/02/28 00:19:16, kinuko wrote:
> getLoaderExecutionContext must be called on the main thread.

Added DCHECK(isMainThread()) in getLoaderExecutionContext().

> postTaskToLoader must be called from the worker thread, so let's also change
> 'can be' -> 'must be'

Done.

[nhiroki, 2017-02-28 01:11:20]

nhiroki@chromium.org changed reviewers:
+ haraken@chromium.org

[nhiroki, 2017-02-28 01:11:21]

+haraken, can you review this as an owner of web/? Thanks!

[nhiroki, 2017-02-28 01:11:34]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 01:12:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 01:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 01:38:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2017-02-28 01:46:41]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 01:47:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-02-28 01:56:20]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 01:56:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-28 02:36:00]

LGTM

[nhiroki, 2017-02-28 04:10:12]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2017-02-28 04:10:16]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-02-28 04:10:17]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2721543002/#ps100001
(title: "tweak header comment")

[commit-bot: I haz the power, 2017-02-28 04:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 04:47:42]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488255016569600,
"parent_rev": "eb9a657134f60d44627d5f768e4db1035cfa0849", "commit_rev":
"0decaefae68c308e45aad3b3fbda9c5b9a6793a8"}

[commit-bot: I haz the power, 2017-02-28 04:48:19]

Description was changed from

==========
SharedWorker: Factor out WorkerReportingProxy impl from WebSharedWorkerImpl

WebSharedWorkerImpl is a heavily threaded class. Some methods are called on the
main thread, while others are called on a worker thread. This often confuses my
head...

This CL factors out a part of WebSharedWorkerImpl that implement
WorkerReportingProxy and are called on a worker thread into
WebSharedWorkerReportingProxyImpl. Even with this cleanup, some methods called
on a worker thread still remain in WebSharedWorkerImpl, but this would somewhat
mitigate the situation and make threading boundary clearer.

BUG=673711
==========

to

==========
SharedWorker: Factor out WorkerReportingProxy impl from WebSharedWorkerImpl

WebSharedWorkerImpl is a heavily threaded class. Some methods are called on the
main thread, while others are called on a worker thread. This often confuses my
head...

This CL factors out a part of WebSharedWorkerImpl that implement
WorkerReportingProxy and are called on a worker thread into
WebSharedWorkerReportingProxyImpl. Even with this cleanup, some methods called
on a worker thread still remain in WebSharedWorkerImpl, but this would somewhat
mitigate the situation and make threading boundary clearer.

BUG=673711

Review-Url: https://codereview.chromium.org/2721543002
Cr-Commit-Position: refs/heads/master@{#453499}
Committed:
https://chromium.googlesource.com/chromium/src/+/0decaefae68c308e45aad3b3fbda...
==========

[commit-bot: I haz the power, 2017-02-28 04:48:22]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/0decaefae68c308e45aad3b3fbda...