Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2721493002: Gtk3: Fix GtkTextView colors (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Fix GtkTextView colors This CL fixes a regression caused by https://codereview.chromium.org/2701923002/ There was a last-minute change from GtkEntry to GtkTextView, but I incorrectly assumed that selection and text colors would be handled in the same way. BUG=79722 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2721493002 Cr-Commit-Position: refs/heads/master@{#453288} Committed: https://chromium.googlesource.com/chromium/src/+/10b633b595d245bf4cfb534a38468e40da4fa448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -30 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 1 chunk +1 line, -17 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 2 chunks +21 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
Tom (Use chromium acct)
3 years, 9 months ago (2017-02-27 17:46:26 UTC) #3
Elliot Glaysher
lgtm
3 years, 9 months ago (2017-02-27 18:15:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721493002/1
3 years, 9 months ago (2017-02-27 19:07:25 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:18:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10b633b595d245bf4cfb534a3846...

Powered by Google App Engine
This is Rietveld 408576698