Gtk3: Refactor GtkButtonImageSource::GetImageForScale

Gtk3: Refactor GtkButtonImageSource::GetImageForScale

This CL refactors GetImageForScale() on Gtk3 so no widget gets created.  Only
a GtkStyleContext is needed.

In addition, it adds GtkStateFlagFocused to the style context if |focus_| is true.
This fixes focused button rendering on Ambiance, which doesn't use a focus
rectangle, but instead changes the button's border directly.

BUG=695357
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2715153002
Cr-Commit-Position: refs/heads/master@{#453292}
Committed: https://chromium.googlesource.com/chromium/src/+/e9b9fb0998172808d880ca208685d8007b8f5a6e

[Tom (Use chromium acct), 2017-02-27 17:48:05]

Description was changed from

==========
Gtk3: Fix focused button rendering

BUG=
==========

to

==========
Gtk3: Fix focused button rendering

BUG=695357
==========

[Tom (Use chromium acct), 2017-02-27 17:51:22]

Description was changed from

==========
Gtk3: Fix focused button rendering

BUG=695357
==========

to

==========
Gtk3: Refactor GtkButtonImageSource::GetImageForScale

This CL refactors GetImageForScale() on Gtk3 so no widget gets created.  Only
a GtkStyleContext is needed.

In addition, it adds GtkStateFlagFocused to the style context if |focus_| is
true.
This fixes focused button rendering on Ambiance, which doesn't use a focus
rectangle, but instead changes the button's border directly.

BUG=695357
R=erg@chromium.org
==========

[Tom (Use chromium acct), 2017-02-27 17:51:22]

thomasanderson@google.com changed reviewers:
+ erg@chromium.org

[Tom (Use chromium acct), 2017-02-27 18:15:50]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 18:16:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-02-27 18:18:31]

lgtm

[commit-bot: I haz the power, 2017-02-27 19:09:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 19:09:16]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2017-02-27 19:19:25]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-02-27 19:19:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:25:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488223165657020, "parent_rev":
"13dd2cb9a8ed7bf0fc7fd88390f3467f1eada817", "commit_rev":
"e9b9fb0998172808d880ca208685d8007b8f5a6e"}

[commit-bot: I haz the power, 2017-02-27 19:26:35]

Description was changed from

==========
Gtk3: Refactor GtkButtonImageSource::GetImageForScale

This CL refactors GetImageForScale() on Gtk3 so no widget gets created.  Only
a GtkStyleContext is needed.

In addition, it adds GtkStateFlagFocused to the style context if |focus_| is
true.
This fixes focused button rendering on Ambiance, which doesn't use a focus
rectangle, but instead changes the button's border directly.

BUG=695357
R=erg@chromium.org
==========

to

==========
Gtk3: Refactor GtkButtonImageSource::GetImageForScale

This CL refactors GetImageForScale() on Gtk3 so no widget gets created.  Only
a GtkStyleContext is needed.

In addition, it adds GtkStateFlagFocused to the style context if |focus_| is
true.
This fixes focused button rendering on Ambiance, which doesn't use a focus
rectangle, but instead changes the button's border directly.

BUG=695357
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2715153002
Cr-Commit-Position: refs/heads/master@{#453292}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9b9fb0998172808d880ca208685...
==========

[commit-bot: I haz the power, 2017-02-27 19:26:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9b9fb0998172808d880ca208685...