Fix obviously broken SVG parsing test

Fix obviously broken SVG parsing test

While running LayoutTests, this test timed out. I was curious, looked into it, and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert function being garbage. This caused 1000s of failures which caused test to run slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of a second, and triggers fewer failures.

Running LayoutTests on my local machine was impossible, so I have not generated new test expectations.

BUG=697646
Review-Url: https://codereview.chromium.org/2721243004
Cr-Commit-Position: refs/heads/master@{#456127}
Committed: https://chromium.googlesource.com/chromium/src/+/d3d4d93c503aa6b59908bb7bda912bd22a7fd1fa

[atotic, 2017-03-01 23:22:30]

Description was changed from

==========
Fix obviously broken SVG parsing test

BUG=697646
==========

to

==========
Fix obviously broken SVG parsing test

While running LayoutTests, this test timed out. I was curious, looked into it,
and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert
function being garbage. This caused 1000s of failures which caused test to run
slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of
a second, and triggers fewer failures.

BUG=697646
==========

[atotic, 2017-03-01 23:22:30]

atotic@chromium.org changed reviewers:
+ pdr@chromium.org

[atotic, 2017-03-03 02:37:18]

Description was changed from

==========
Fix obviously broken SVG parsing test

While running LayoutTests, this test timed out. I was curious, looked into it,
and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert
function being garbage. This caused 1000s of failures which caused test to run
slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of
a second, and triggers fewer failures.

BUG=697646
==========

to

==========
Fix obviously broken SVG parsing test

While running LayoutTests, this test timed out. I was curious, looked into it,
and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert
function being garbage. This caused 1000s of failures which caused test to run
slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of
a second, and triggers fewer failures.

Running LayoutTests on my local machine was impossible, so I have not generated
new test expectations.

BUG=697646
==========

[atotic, 2017-03-03 02:37:18]

atotic@chromium.org changed reviewers:
+ schenney@chromium.org
- pdr@chromium.org

[Stephen Chennney, 2017-03-03 15:14:42]

The change looks good in that it gets us coverage at least as good as we should
have now. I'm not sure it catches all the cases but that's not required for this
patch.

I've started trybots to get new test expectations. When the bots finish you can
use "webkit-patch rebaseline-cl" to pull the new baselines from the bots and
upload them for review.

[Stephen Chennney, 2017-03-03 15:15:01]

Description was changed from

==========
Fix obviously broken SVG parsing test

While running LayoutTests, this test timed out. I was curious, looked into it,
and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert
function being garbage. This caused 1000s of failures which caused test to run
slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of
a second, and triggers fewer failures.

Running LayoutTests on my local machine was impossible, so I have not generated
new test expectations.

BUG=697646
==========

to

==========
Fix obviously broken SVG parsing test

While running LayoutTests, this test timed out. I was curious, looked into it,
and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert
function being garbage. This caused 1000s of failures which caused test to run
slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of
a second, and triggers fewer failures.

Running LayoutTests on my local machine was impossible, so I have not generated
new test expectations.

BUG=697646
==========

[atotic, 2017-03-03 17:26:03]

On 2017/03/03 at 15:14:42, schenney wrote:
> The change looks good in that it gets us coverage at least as good as we
should have now. I'm not sure it catches all the cases but that's not required
for this patch.
> 
> I've started trybots to get new test expectations. When the bots finish you
can use "webkit-patch rebaseline-cl" to pull the new baselines from the bots and
upload them for review.

Trying to run tests yesterday blew away my home directory. I'll get back to this
when it restores.

https://bugs.chromium.org/p/chromium/issues/detail?id=697954

[atotic, 2017-03-07 00:04:32]

On 2017/03/03 at 17:26:03, atotic wrote:
> On 2017/03/03 at 15:14:42, schenney wrote:
> > The change looks good in that it gets us coverage at least as good as we
should have now. I'm not sure it catches all the cases but that's not required
for this patch.
> > 
> > I've started trybots to get new test expectations. When the bots finish you
can use "webkit-patch rebaseline-cl" to pull the new baselines from the bots and
upload them for review.
> 
> Trying to run tests yesterday blew away my home directory. I'll get back to
this when it restores.
> 
> https://bugs.chromium.org/p/chromium/issues/detail?id=697954

My patch got lost when the HOME directory got blown away. Would you like to take
this over?

[Stephen Chennney, 2017-03-07 14:49:32]

On 2017/03/07 00:04:32, atotic wrote:
> On 2017/03/03 at 17:26:03, atotic wrote:
> > On 2017/03/03 at 15:14:42, schenney wrote:
> > > The change looks good in that it gets us coverage at least as good as we
> should have now. I'm not sure it catches all the cases but that's not required
> for this patch.
> > > 
> > > I've started trybots to get new test expectations. When the bots finish
you
> can use "webkit-patch rebaseline-cl" to pull the new baselines from the bots
and
> upload them for review.
> > 
> > Trying to run tests yesterday blew away my home directory. I'll get back to
> this when it restores.
> > 
> > https://bugs.chromium.org/p/chromium/issues/detail?id=697954
> 
> My patch got lost when the HOME directory got blown away. Would you like to
take
> this over?

If you have a checkout you can re-apply this patch to that checkout. Get onto a
new git branch then use "git cl patch 2721243004", where the number is the patch
ID of this patch.

Let me know if this does not solve your problem and I will take it on.

[atotic, 2017-03-08 22:48:08]

ptal, rebaselined the test

[Stephen Chennney, 2017-03-10 18:06:04]

The CQ bit was checked by schenney@chromium.org

[Stephen Chennney, 2017-03-10 18:06:05]

lgtm

[commit-bot: I haz the power, 2017-03-10 18:06:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 19:16:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489169164926020,
"parent_rev": "ea1c1679e17de2aebbdbeab39149b1890914b260", "commit_rev":
"d3d4d93c503aa6b59908bb7bda912bd22a7fd1fa"}

[commit-bot: I haz the power, 2017-03-10 19:16:46]

Description was changed from

==========
Fix obviously broken SVG parsing test

While running LayoutTests, this test timed out. I was curious, looked into it,
and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert
function being garbage. This caused 1000s of failures which caused test to run
slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of
a second, and triggers fewer failures.

Running LayoutTests on my local machine was impossible, so I have not generated
new test expectations.

BUG=697646
==========

to

==========
Fix obviously broken SVG parsing test

While running LayoutTests, this test timed out. I was curious, looked into it,
and realized that the test was completely broken:

1) there was an extra argument getting passed to testType() resulting in assert
function being garbage. This caused 1000s of failures which caused test to run
slowly.

2) Some other arguments being passed in were also wrong.

My fix is not perfect, but it results in a saner outcome: it runs in fraction of
a second, and triggers fewer failures.

Running LayoutTests on my local machine was impossible, so I have not generated
new test expectations.

BUG=697646

Review-Url: https://codereview.chromium.org/2721243004
Cr-Commit-Position: refs/heads/master@{#456127}
Committed:
https://chromium.googlesource.com/chromium/src/+/d3d4d93c503aa6b59908bb7bda91...
==========

[commit-bot: I haz the power, 2017-03-10 19:16:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d3d4d93c503aa6b59908bb7bda91...