third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html - Issue 2721243004: Fix obviously broken SVG parsing test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html

Issue 2721243004: Fix obviously broken SVG parsing test (Closed)

Patch Set: git cl web Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html

diff --git a/third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html b/third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html

index c09d961eb2e498f45ecf343e69e3c86318b79bb8..10b4a30755bcdc2ab45ff93a81ef4c7eb6717be7 100644

--- a/third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html

+++ b/third_party/WebKit/LayoutTests/svg/parser/whitespace-integer.html

@@ -1,4 +1,4 @@

-<!doctype html>

+<!doctype html>

<title>Whitespace in attribute values tests</title>

@@ -18,7 +18,7 @@ var svg = document.querySelector("svg");

// test length values

var EPSILON = Math.pow(2, -24); // float epsilon

-var whitespace = [ "", " ", " ", "\r\n\t ", "\f" ];

+var whitespace = [ "", " ", " " ];

var garbage = [ "a", "e", "foo", ")90" ];

var validunits = [ "", "em", "ex", "px", "in", "cm", "mm", "pt", "pc", "%" ];

@@ -28,8 +28,7 @@ testType("<integer>",

0, // expected default value (FIXME: should be 1)

whitespace,

[ "-47", "0", "+32", "1241245" ],

- [ Number.NaN, Number.POSITIVE_INFINITY, Number.NEGATIVE_INFINITY, "fnord", "E", "e", "e+", "E-", "-", "+", "-.", ".-", ".", "+.", ".E0", "e1", "+17E-1", "17e+2", "0.35", "1e-10", ".1" ],

- [""], // valid units

+ validunits,

garbage,

function(elm, value) { assert_equals(elm.numOctaves.baseVal, parseInt(value)); },

function(elm, expected) { assert_equals(elm.numOctaves.baseVal, expected); } );

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/parser/whitespace-integer-expected.txt » ('j') | no next file with comments »