Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2721233003: DevTools: create help sub-menu (Closed)

Created:
3 years, 9 months ago by chenwilliam
Modified:
3 years, 9 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: create help sub-menu BUG=682879 Review-Url: https://codereview.chromium.org/2721233003 Cr-Commit-Position: refs/heads/master@{#454172} Committed: https://chromium.googlesource.com/chromium/src/+/f6e4032c2c94f990c67ae2c0f68ffc18250d1f79

Patch Set 1 #

Total comments: 6

Patch Set 2 : cl fb #

Patch Set 3 : cl fb #

Patch Set 4 : fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/module.json View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/module.json View 1 2 3 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
chenwilliam
@alph - @chowse suggested moving keyboard shortcuts menu item to the help submenu and also ...
3 years, 9 months ago (2017-03-01 02:30:40 UTC) #2
alph
https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode754 third_party/WebKit/Source/devtools/front_end/main/Main.js:754: helpSubMenu.appendItem('Release Note', () => InspectorFrontendHost.openInNewTab(Help.latestReleaseNote().link)); Release Notes? https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/module.json File ...
3 years, 9 months ago (2017-03-01 17:26:47 UTC) #3
chenwilliam
ptal. https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode754 third_party/WebKit/Source/devtools/front_end/main/Main.js:754: helpSubMenu.appendItem('Release Note', () => InspectorFrontendHost.openInNewTab(Help.latestReleaseNote().link)); On 2017/03/01 17:26:47, ...
3 years, 9 months ago (2017-03-01 19:43:26 UTC) #4
alph
https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/module.json File third_party/WebKit/Source/devtools/front_end/settings/module.json (left): https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/module.json#oldcode18 third_party/WebKit/Source/devtools/front_end/settings/module.json:18: "actionId": "settings.help", On 2017/03/01 19:43:26, chenwilliam wrote: > On ...
3 years, 9 months ago (2017-03-01 22:58:42 UTC) #5
alph
https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/module.json File third_party/WebKit/Source/devtools/front_end/settings/module.json (left): https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/module.json#oldcode18 third_party/WebKit/Source/devtools/front_end/settings/module.json:18: "actionId": "settings.help", On 2017/03/01 19:43:26, chenwilliam wrote: > On ...
3 years, 9 months ago (2017-03-01 22:58:42 UTC) #6
chenwilliam
ptal. https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/module.json File third_party/WebKit/Source/devtools/front_end/settings/module.json (left): https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/devtools/front_end/settings/module.json#oldcode18 third_party/WebKit/Source/devtools/front_end/settings/module.json:18: "actionId": "settings.help", On 2017/03/01 22:58:42, alph wrote: > ...
3 years, 9 months ago (2017-03-02 00:26:20 UTC) #7
alph
lgtm
3 years, 9 months ago (2017-03-02 00:44:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721233003/60001
3 years, 9 months ago (2017-03-02 01:03:27 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 03:50:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f6e4032c2c94f990c67ae2c0f68f...

Powered by Google App Engine
This is Rietveld 408576698