DevTools: create help sub-menu

DevTools: create help sub-menu

BUG=682879
Review-Url: https://codereview.chromium.org/2721233003
Cr-Commit-Position: refs/heads/master@{#454172}
Committed: https://chromium.googlesource.com/chromium/src/+/f6e4032c2c94f990c67ae2c0f68ffc18250d1f79

[chenwilliam, 2017-03-01 02:30:39]

chenwilliam@chromium.org changed reviewers:
+ alph@chromium.org

[chenwilliam, 2017-03-01 02:30:40]

@alph - @chowse suggested moving keyboard shortcuts menu item to the help
submenu and also adding "Report a bug" and "Follow us on Twitter" menu items to
the help sub-menu. what do you think?

[alph, 2017-03-01 17:26:47]

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:754:
helpSubMenu.appendItem('Release Note', () =>
InspectorFrontendHost.openInNewTab(Help.latestReleaseNote().link));
Release Notes?

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/settings/module.json (left):

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/settings/module.json:18:
"actionId": "settings.help",
why removing this?

[chenwilliam, 2017-03-01 19:43:26]

ptal.

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/main/Main.js:754:
helpSubMenu.appendItem('Release Note', () =>
InspectorFrontendHost.openInNewTab(Help.latestReleaseNote().link));
On 2017/03/01 17:26:47, alph wrote:
> Release Notes?

Done.

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/settings/module.json (left):

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/settings/module.json:18:
"actionId": "settings.help",
On 2017/03/01 17:26:47, alph wrote:
> why removing this?

I'm doing this imperatively in Main.js because I couldn't figure out how to
define a submenu item & action in a module.json. Is there a way of declaring
submenu items in module.json?

[alph, 2017-03-01 22:58:42]

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/settings/module.json (left):

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/settings/module.json:18:
"actionId": "settings.help",
On 2017/03/01 19:43:26, chenwilliam wrote:
> On 2017/03/01 17:26:47, alph wrote:
> > why removing this?
> 
> I'm doing this imperatively in Main.js because I couldn't figure out how to
> define a submenu item & action in a module.json. Is there a way of declaring
> submenu items in module.json? 

Hot sure about submenu, but could you please keep the action?

[alph, 2017-03-01 22:58:42]

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/settings/module.json (left):

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/settings/module.json:18:
"actionId": "settings.help",
On 2017/03/01 19:43:26, chenwilliam wrote:
> On 2017/03/01 17:26:47, alph wrote:
> > why removing this?
> 
> I'm doing this imperatively in Main.js because I couldn't figure out how to
> define a submenu item & action in a module.json. Is there a way of declaring
> submenu items in module.json? 

Hot sure about submenu, but could you please keep the action?

[chenwilliam, 2017-03-02 00:26:20]

ptal.

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/settings/module.json (left):

https://codereview.chromium.org/2721233003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/settings/module.json:18:
"actionId": "settings.help",
On 2017/03/01 22:58:42, alph wrote:
> On 2017/03/01 19:43:26, chenwilliam wrote:
> > On 2017/03/01 17:26:47, alph wrote:
> > > why removing this?
> > 
> > I'm doing this imperatively in Main.js because I couldn't figure out how to
> > define a submenu item & action in a module.json. Is there a way of declaring
> > submenu items in module.json? 
> 
> Hot sure about submenu, but could you please keep the action?

Done.

[alph, 2017-03-02 00:44:03]

lgtm

[chenwilliam, 2017-03-02 01:02:58]

The CQ bit was checked by chenwilliam@chromium.org

[commit-bot: I haz the power, 2017-03-02 01:03:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 03:49:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488416578531810,
"parent_rev": "41fec5d557eb60cc7eecb200adb80d1f96b24558", "commit_rev":
"f6e4032c2c94f990c67ae2c0f68ffc18250d1f79"}

[commit-bot: I haz the power, 2017-03-02 03:50:29]

Description was changed from

==========
DevTools: create help sub-menu

BUG=682879
==========

to

==========
DevTools: create help sub-menu

BUG=682879

Review-Url: https://codereview.chromium.org/2721233003
Cr-Commit-Position: refs/heads/master@{#454172}
Committed:
https://chromium.googlesource.com/chromium/src/+/f6e4032c2c94f990c67ae2c0f68f...
==========

[commit-bot: I haz the power, 2017-03-02 03:50:30]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f6e4032c2c94f990c67ae2c0f68f...