Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 { | 1 { |
| 2 "extensions": [ | 2 "extensions": [ |
| 3 { | 3 { |
| 4 "type": "@UI.ActionDelegate", | 4 "type": "@UI.ActionDelegate", |
| 5 "category": "Settings", | 5 "category": "Settings", |
| 6 "actionId": "settings.show", | 6 "actionId": "settings.show", |
| 7 "title": "Settings", | 7 "title": "Settings", |
| 8 "className": "Settings.SettingsScreen.ActionDelegate", | 8 "className": "Settings.SettingsScreen.ActionDelegate", |
| 9 "bindings": [ | 9 "bindings": [ |
| 10 { | 10 { |
| 11 "shortcut": "F1 Shift+?" | 11 "shortcut": "F1 Shift+?" |
| 12 } | 12 } |
| 13 ] | 13 ] |
| 14 }, | 14 }, |
| 15 { | 15 { |
| 16 "type": "@UI.ActionDelegate", | 16 "type": "@UI.ActionDelegate", |
| 17 "category": "Settings", | 17 "category": "Settings", |
| 18 "actionId": "settings.help", | |
|
alph
2017/03/01 17:26:47
why removing this?
chenwilliam
2017/03/01 19:43:26
I'm doing this imperatively in Main.js because I c
alph
2017/03/01 22:58:42
Hot sure about submenu, but could you please keep
chenwilliam
2017/03/02 00:26:20
Done.
| |
| 19 "title": "Help", | |
| 20 "className": "Settings.SettingsScreen.ActionDelegate" | |
| 21 }, | |
| 22 { | |
| 23 "type": "@UI.ActionDelegate", | |
| 24 "category": "Settings", | |
| 25 "actionId": "settings.shortcuts", | 18 "actionId": "settings.shortcuts", |
| 26 "title": "Shortcuts", | 19 "title": "Shortcuts", |
| 27 "className": "Settings.SettingsScreen.ActionDelegate" | 20 "className": "Settings.SettingsScreen.ActionDelegate" |
| 28 }, | 21 }, |
| 29 { | 22 { |
| 30 "type": "@Common.Revealer", | 23 "type": "@Common.Revealer", |
| 31 "contextTypes": ["Common.Setting"], | 24 "contextTypes": ["Common.Setting"], |
| 32 "className": "Settings.SettingsScreen.Revealer" | 25 "className": "Settings.SettingsScreen.Revealer" |
| 33 }, | 26 }, |
| 34 { | 27 { |
| 35 "type": "context-menu-item", | 28 "type": "context-menu-item", |
| 36 "location": "mainMenu/footer", | 29 "location": "mainMenu/footer", |
| 37 "order": 10, | 30 "order": 10, |
| 38 "actionId": "settings.shortcuts" | 31 "actionId": "settings.shortcuts" |
| 39 }, | 32 }, |
| 40 { | 33 { |
| 41 "type": "context-menu-item", | 34 "type": "context-menu-item", |
| 42 "location": "mainMenu/footer", | 35 "location": "mainMenu/footer", |
| 43 "order": 20, | 36 "order": 20, |
| 44 "actionId": "settings.show" | 37 "actionId": "settings.show" |
| 45 }, | 38 }, |
| 46 { | 39 { |
| 47 "type": "context-menu-item", | |
| 48 "location": "mainMenu/footer", | |
| 49 "order": 30, | |
| 50 "actionId": "settings.help" | |
| 51 }, | |
| 52 { | |
| 53 "type": "view", | 40 "type": "view", |
| 54 "location": "settings-view", | 41 "location": "settings-view", |
| 55 "id": "preferences", | 42 "id": "preferences", |
| 56 "title": "Preferences", | 43 "title": "Preferences", |
| 57 "order": "0", | 44 "order": "0", |
| 58 "className": "Settings.GenericSettingsTab" | 45 "className": "Settings.GenericSettingsTab" |
| 59 }, | 46 }, |
| 60 { | 47 { |
| 61 "type": "view", | 48 "type": "view", |
| 62 "location": "settings-view", | 49 "location": "settings-view", |
| (...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 95 "EditFileSystemView.js", | 82 "EditFileSystemView.js", |
| 96 "SettingsScreen.js", | 83 "SettingsScreen.js", |
| 97 "FrameworkBlackboxSettingsTab.js" | 84 "FrameworkBlackboxSettingsTab.js" |
| 98 ], | 85 ], |
| 99 "resources": [ | 86 "resources": [ |
| 100 "editFileSystemView.css", | 87 "editFileSystemView.css", |
| 101 "frameworkBlackboxSettingsTab.css", | 88 "frameworkBlackboxSettingsTab.css", |
| 102 "settingsScreen.css" | 89 "settingsScreen.css" |
| 103 ] | 90 ] |
| 104 } | 91 } |
| OLD | NEW |