Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2721203006: Add warning and error markers to some tests (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M tests/language_strong/super_setter_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language_strong/try_catch4_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/language_strong/try_catch5_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-02 18:58:10 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-02 18:58:59 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-02 19:01:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5ad5ac72d168b4b454afc943e7f27fd8e812793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698