Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Side by Side Diff: tests/language_strong/try_catch5_test.dart

Issue 2721203006: Add warning and error markers to some tests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/language_strong/try_catch4_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Check that our SSA graph does have the try body a predecessor of a 4 // Check that our SSA graph does have the try body a predecessor of a
5 // try/finally. 5 // try/finally.
6 // VMOptions=--optimization-counter-threshold=10 6 // VMOptions=--optimization-counter-threshold=10
7 7
8 import "package:expect/expect.dart"; 8 import "package:expect/expect.dart";
9 9
10 var a; 10 var a;
11 11
12 foo1() { 12 foo1() {
13 var b = false; 13 var b = false;
14 var entered = false; 14 var entered = false;
15 while (true) { 15 while (true) {
16 if (entered) return b; 16 if (entered) return b; /// static warning
17 b = 8 == a; // This expression should not be GVN'ed. 17 b = 8 == a; // This expression should not be GVN'ed.
18 try { 18 try {
19 try { 19 try {
20 a = 8; 20 a = 8;
21 return; 21 return; /// static warning
22 } finally { 22 } finally {
23 b = 8 == a; 23 b = 8 == a;
24 entered = true; 24 entered = true;
25 continue; 25 continue;
26 } 26 }
27 } finally { 27 } finally {
28 continue; 28 continue;
29 } 29 }
30 } 30 }
31 } 31 }
32 32
33 main() { 33 main() {
34 for (var i = 0; i < 20; i++) { 34 for (var i = 0; i < 20; i++) {
35 a = 0; 35 a = 0;
36 Expect.isTrue(foo1()); 36 Expect.isTrue(foo1());
37 } 37 }
38 } 38 }
OLDNEW
« no previous file with comments | « tests/language_strong/try_catch4_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698