Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: tests/language_strong/try_catch5_test.dart

Issue 2721203006: Add warning and error markers to some tests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language_strong/try_catch4_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language_strong/try_catch5_test.dart
diff --git a/tests/language_strong/try_catch5_test.dart b/tests/language_strong/try_catch5_test.dart
index 5aa16e91e234a4e49ed005d4e37313cb38a0cbe0..2b6d862b2457bd9b92496daff779b1a416fe7625 100644
--- a/tests/language_strong/try_catch5_test.dart
+++ b/tests/language_strong/try_catch5_test.dart
@@ -13,12 +13,12 @@ foo1() {
var b = false;
var entered = false;
while (true) {
- if (entered) return b;
+ if (entered) return b; /// static warning
b = 8 == a; // This expression should not be GVN'ed.
try {
try {
a = 8;
- return;
+ return; /// static warning
} finally {
b = 8 == a;
entered = true;
« no previous file with comments | « tests/language_strong/try_catch4_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698