Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2721103002: mash_unittests: Enable RootWindowControllerTest.MoveWindows_Basic. (Closed)

Created:
3 years, 9 months ago by Elliot Glaysher
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash_unittests: Enable RootWindowControllerTest.MoveWindows_Basic. MoveWindows_Basic tests a lot of functionality all in one test. We don't have enough of the display management system built to test the details of display changes, though. So move the one check we can't yet pass behind an if instead of disabling the entire thing. BUG=695632 Review-Url: https://codereview.chromium.org/2721103002 Cr-Commit-Position: refs/heads/master@{#453775} Committed: https://chromium.googlesource.com/chromium/src/+/2ee93828200a82947abf0d497c4b898b54c9b87d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -18 lines) Patch
M ash/root_window_controller_unittest.cc View 2 chunks +26 lines, -18 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Elliot Glaysher
3 years, 9 months ago (2017-02-28 22:51:24 UTC) #7
sky
LGTM
3 years, 9 months ago (2017-03-01 00:32:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721103002/1
3 years, 9 months ago (2017-03-01 00:34:17 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 00:42:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ee93828200a82947abf0d497c4b...

Powered by Google App Engine
This is Rietveld 408576698