Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: ash/test/ash_test_helper.cc

Issue 2721103002: mash_unittests: Enable RootWindowControllerTest.MoveWindows_Basic. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/root_window_controller_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/test/ash_test_helper.cc
diff --git a/ash/test/ash_test_helper.cc b/ash/test/ash_test_helper.cc
index 1508abf21cb0b2dfc609b8dc7d7566c24c5235f8..7421eec716f78ca26da957e83c8ad050fefdf6d0 100644
--- a/ash/test/ash_test_helper.cc
+++ b/ash/test/ash_test_helper.cc
@@ -235,6 +235,13 @@ aura::Window* AshTestHelper::CurrentContext() {
}
void AshTestHelper::UpdateDisplayForMash(const std::string& display_spec) {
+ // TODO(erg): This is not equivalent to display::DisplayManager::
+ // UpdateDisplaysWith(). This does not calculate all the internal metric
+ // changes, does not calculate focus changes and does not dispatch to all the
+ // observers in ash which want to be notified about the previous two.
+ //
+ // Once this is fixed, RootWindowControllerTest.MoveWindows_Basic, among
+ // other unit tests, should work. http://crbug.com/695632.
CHECK(IsMash());
const std::vector<std::string> parts = base::SplitString(
display_spec, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
« no previous file with comments | « ash/root_window_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698