Roll breakpad 37070c5..10162f6

Roll breakpad 37070c5..10162f6

10162f6 win: Set LargeAddressAware on symupload
eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.

Previous attempts https://codereview.chromium.org/2719553002 and
https://codereview.chromium.org/2718173002. This time, we have both a
MSVS 2013 build, and the LargeAddressAware flag set on the .exe.

[roll-breakpad-3]c:\src\cr\src>dumpbin /headers breakpad\symupload.exe | grep linker
           12.00 linker version

[roll-breakpad-3]c:\src\cr\src>dumpbin /headers breakpad\symupload.exe | grep large
                   Application can handle large (>2GB) addresses

R=mark@chromium.org
BUG=678874, 696257, 696671, 696911
Review-Url: https://codereview.chromium.org/2720873004
Cr-Commit-Position: refs/heads/master@{#453702}
Committed: https://chromium.googlesource.com/chromium/src/+/7f67e4310802a5f05d702276d5111c9b99391921

[scottmg, 2017-02-28 19:34:27]

Description was changed from

==========
Roll breakpad 37070c5..10162f6

10162f6 win: Set LargeAddressAware on symupload
eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.

Previous attempts https://codereview.chromium.org/2719553002 and
https://codereview.chromium.org/2718173002. This time, we have both a
MSVS 2013 build, and the LargeAddressAware flag set on the .exe.

R=mark@chromium.org
BUG=678874,696257,696671,696911
==========

to

==========
Roll breakpad 37070c5..10162f6

10162f6 win: Set LargeAddressAware on symupload
eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.

Previous attempts https://codereview.chromium.org/2719553002 and
https://codereview.chromium.org/2718173002. This time, we have both a
MSVS 2013 build, and the LargeAddressAware flag set on the .exe.

[roll-breakpad-3]c:\src\cr\src>dumpbin /headers breakpad\symupload.exe | grep
linker
           12.00 linker version

[roll-breakpad-3]c:\src\cr\src>dumpbin /headers breakpad\symupload.exe | grep
large
                   Application can handle large (>2GB) addresses

R=mark@chromium.org
BUG=678874,696257,696671,696911
==========

[scottmg, 2017-02-28 19:34:36]

Patchset #1 (id:1) has been deleted

[scottmg, 2017-02-28 19:34:51]

Play it again, Sam.

[scottmg, 2017-02-28 19:35:01]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 19:35:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-02-28 20:09:16]

LGTM. But you'll regret it. Maybe not today, maybe not tomorrow, but soon, and
for the rest of your life.

[scottmg, 2017-02-28 20:26:26]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2017-02-28 20:26:28]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2017-02-28 20:26:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 21:14:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488313588725840,
"parent_rev": "087deb321baa68111033bbe9e74d1ef255606ac3", "commit_rev":
"7f67e4310802a5f05d702276d5111c9b99391921"}

[commit-bot: I haz the power, 2017-02-28 21:14:53]

Description was changed from

==========
Roll breakpad 37070c5..10162f6

10162f6 win: Set LargeAddressAware on symupload
eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.

Previous attempts https://codereview.chromium.org/2719553002 and
https://codereview.chromium.org/2718173002. This time, we have both a
MSVS 2013 build, and the LargeAddressAware flag set on the .exe.

[roll-breakpad-3]c:\src\cr\src>dumpbin /headers breakpad\symupload.exe | grep
linker
           12.00 linker version

[roll-breakpad-3]c:\src\cr\src>dumpbin /headers breakpad\symupload.exe | grep
large
                   Application can handle large (>2GB) addresses

R=mark@chromium.org
BUG=678874,696257,696671,696911
==========

to

==========
Roll breakpad 37070c5..10162f6

10162f6 win: Set LargeAddressAware on symupload
eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.

Previous attempts https://codereview.chromium.org/2719553002 and
https://codereview.chromium.org/2718173002. This time, we have both a
MSVS 2013 build, and the LargeAddressAware flag set on the .exe.

[roll-breakpad-3]c:\src\cr\src>dumpbin /headers breakpad\symupload.exe | grep
linker
           12.00 linker version

[roll-breakpad-3]c:\src\cr\src>dumpbin /headers breakpad\symupload.exe | grep
large
                   Application can handle large (>2GB) addresses

R=mark@chromium.org
BUG=678874,696257,696671,696911

Review-Url: https://codereview.chromium.org/2720873004
Cr-Commit-Position: refs/heads/master@{#453702}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f67e4310802a5f05d702276d511...
==========

[commit-bot: I haz the power, 2017-02-28 21:14:57]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f67e4310802a5f05d702276d511...