Roll breakpad 37070c5..eaedc45

Roll breakpad 37070c5..eaedc45

eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.

Previous reverted attempt was
https://codereview.chromium.org/2719553002. This rolls in the same code.
However, this time symupload was instead built with VS2013. I confirmed
the link line included:

/LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 12.0\/DIA SDK/lib"

and:

c:\src\cr\src\breakpad>dumpbin /headers symupload.exe | grep linker
           12.00 linker version

This is expected to help because the suspicion is that only msdia120.dll
is registered on official bots, not msdia140.dll.

R=mark@chromium.org
BUG=678874, 696257, 696671
Review-Url: https://codereview.chromium.org/2718173002
Cr-Commit-Position: refs/heads/master@{#453325}
Committed: https://chromium.googlesource.com/chromium/src/+/5f3ea1407ad98cdb9d8418a52d3dbeff7ec5033e

[scottmg, 2017-02-27 19:33:11]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 19:33:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-02-27 20:07:17]

LGTM. The DIA version available on the bots is the prime suspect.

[scottmg, 2017-02-27 20:12:27]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2017-02-27 20:12:31]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2017-02-27 20:13:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:46:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488226351441300, "parent_rev":
"a9ed8de437e90231d89798e5692a81066fb26cd3", "commit_rev":
"5f3ea1407ad98cdb9d8418a52d3dbeff7ec5033e"}

[commit-bot: I haz the power, 2017-02-27 20:47:36]

Description was changed from

==========
Roll breakpad 37070c5..eaedc45

eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.

Previous reverted attempt was
https://codereview.chromium.org/2719553002. This rolls in the same code.
However, this time symupload was instead built with VS2013. I confirmed
the link line included:

/LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 12.0\/DIA SDK/lib"

and:

c:\src\cr\src\breakpad>dumpbin /headers symupload.exe | grep linker
           12.00 linker version

This is expected to help because the suspicion is that only msdia120.dll
is registered on official bots, not msdia140.dll.

R=mark@chromium.org
BUG=678874,696257,696671
==========

to

==========
Roll breakpad 37070c5..eaedc45

eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.

Previous reverted attempt was
https://codereview.chromium.org/2719553002. This rolls in the same code.
However, this time symupload was instead built with VS2013. I confirmed
the link line included:

/LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 12.0\/DIA SDK/lib"

and:

c:\src\cr\src\breakpad>dumpbin /headers symupload.exe | grep linker
           12.00 linker version

This is expected to help because the suspicion is that only msdia120.dll
is registered on official bots, not msdia140.dll.

R=mark@chromium.org
BUG=678874,696257,696671

Review-Url: https://codereview.chromium.org/2718173002
Cr-Commit-Position: refs/heads/master@{#453325}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f3ea1407ad98cdb9d8418a52d3d...
==========

[commit-bot: I haz the power, 2017-02-27 20:47:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f3ea1407ad98cdb9d8418a52d3d...

[scottmg, 2017-02-28 18:32:17]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2726633002/ by scottmg@chromium.org.

The reason for reverting is: Failing for chrome_child.dll on x86 builds only.
crbug.com/696911..