Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 2718173002: Roll breakpad 37070c5..eaedc45 (Closed)

3 years, 9 months ago by scottmg
3 years, 9 months ago
Mark Mentovai
Target Ref:


Roll breakpad 37070c5..eaedc45 eaedc45 Improve stack sanitization unittests. 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. Previous reverted attempt was This rolls in the same code. However, this time symupload was instead built with VS2013. I confirmed the link line included: /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 12.0\/DIA SDK/lib" and: c:\src\cr\src\breakpad>dumpbin /headers symupload.exe | grep linker 12.00 linker version This is expected to help because the suspicion is that only msdia120.dll is registered on official bots, not msdia140.dll. BUG=678874, 696257, 696671 Review-Url: Cr-Commit-Position: refs/heads/master@{#453325} Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/symupload.exe View Binary file 0 comments Download


Total messages: 11 (6 generated)
3 years, 9 months ago (2017-02-27 19:33:14 UTC) #2
Mark Mentovai
LGTM. The DIA version available on the bots is the prime suspect.
3 years, 9 months ago (2017-02-27 20:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at
3 years, 9 months ago (2017-02-27 20:13:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as
3 years, 9 months ago (2017-02-27 20:47:38 UTC) #10
3 years, 9 months ago (2017-02-28 18:32:17 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in by

The reason for reverting is: Failing for chrome_child.dll on x86 builds only.

Powered by Google App Engine
This is Rietveld 408576698