Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2720723004: Remove FrameHost setDefaultPageScaleLimits/UserAgentPageScaleConstraints (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameHost setDefaultPageScaleLimits/UserAgentPageScaleConstraints BUG=691794 Review-Url: https://codereview.chromium.org/2720723004 Cr-Commit-Position: refs/heads/master@{#454838} Committed: https://chromium.googlesource.com/chromium/src/+/d1bcb71f31974fd109abfe54e3c7bd2827ad504a

Patch Set 1 #

Patch Set 2 : Small fix #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (18 generated)
sashab
3 years, 9 months ago (2017-02-28 05:41:22 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-28 06:32:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720723004/40001
3 years, 9 months ago (2017-03-02 23:58:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/25971)
3 years, 9 months ago (2017-03-03 01:12:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720723004/60001
3 years, 9 months ago (2017-03-06 05:29:11 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 07:43:21 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d1bcb71f31974fd109abfe54e3c7...

Powered by Google App Engine
This is Rietveld 408576698