Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2720673003: [headless] Use version for product name and user agent. (Closed)

Created:
3 years, 9 months ago by Eric Seckler
Modified:
3 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[headless] Use version for product name and user agent. Also sets the product name on DevTools server. BUG=696457 Review-Url: https://codereview.chromium.org/2720673003 Cr-Commit-Position: refs/heads/master@{#453189} Committed: https://chromium.googlesource.com/chromium/src/+/38ff88e55d8c151e1559da02fa1c52aff31c44eb

Patch Set 1 #

Patch Set 2 : also set product in HeadlessContentClient. #

Patch Set 3 : use headless/public/version.h instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M headless/lib/browser/headless_browser_context_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_context_options.h View 2 chunks +2 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_context_options.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_devtools.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M headless/lib/headless_content_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/headless_content_client.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M headless/public/headless_browser.h View 2 chunks +3 lines, -0 lines 0 comments Download
M headless/public/headless_browser.cc View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M headless/public/headless_browser_context.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Eric Seckler
3 years, 9 months ago (2017-02-27 10:30:04 UTC) #2
Eric Seckler
On 2017/02/27 10:30:04, Eric Seckler wrote: Using headless/public/version.h now. PTAL :)
3 years, 9 months ago (2017-02-27 10:40:08 UTC) #3
Sami
lgtm, thanks!
3 years, 9 months ago (2017-02-27 11:08:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720673003/40001
3 years, 9 months ago (2017-02-27 11:13:32 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 11:19:02 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/38ff88e55d8c151e1559da02fa1c...

Powered by Google App Engine
This is Rietveld 408576698