Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: headless/lib/browser/headless_devtools.cc

Issue 2720673003: [headless] Use version for product name and user agent. (Closed)
Patch Set: use headless/public/version.h instead. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_browser_context_options.cc ('k') | headless/lib/headless_content_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/headless_devtools.cc
diff --git a/headless/lib/browser/headless_devtools.cc b/headless/lib/browser/headless_devtools.cc
index ea97afcc96a23a1be728d3a427b9a376694b9125..88b9656a763295c4c01532b51430d3f49f5a9c62 100644
--- a/headless/lib/browser/headless_devtools.cc
+++ b/headless/lib/browser/headless_devtools.cc
@@ -56,15 +56,14 @@ class TCPServerSocketFactory : public content::DevToolsSocketFactory {
} // namespace
-void StartLocalDevToolsHttpHandler(
- HeadlessBrowser::Options* options) {
+void StartLocalDevToolsHttpHandler(HeadlessBrowser::Options* options) {
const net::IPEndPoint& endpoint = options->devtools_endpoint;
std::unique_ptr<content::DevToolsSocketFactory> socket_factory(
new TCPServerSocketFactory(endpoint));
content::DevToolsAgentHost::StartRemoteDebuggingServer(
std::move(socket_factory), std::string(),
options->user_data_dir, // TODO(altimin): Figure a proper value for this.
- base::FilePath(), std::string(), options->user_agent);
+ base::FilePath(), options->product_name_and_version, options->user_agent);
}
void StopLocalDevToolsHttpHandler() {
« no previous file with comments | « headless/lib/browser/headless_browser_context_options.cc ('k') | headless/lib/headless_content_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698