Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

Issue 2720513003: Reland: Switch WindowedNotificationObserver to use base::RunLoop. (Closed)
Patch Set: Fix DeviceLocalAccountExternalPolicyLoaderTest.ForceInstallListSet. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/login_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc b/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
index 01008ae629792fcc886525527fe5615ab92c31ae..259f34fa072f051f24da0185780a1b34504281e5 100644
--- a/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
+++ b/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
@@ -265,6 +265,12 @@ TEST_F(DeviceLocalAccountExternalPolicyLoaderTest, ForceInstallListSet) {
content::WindowedNotificationObserver(
extensions::NOTIFICATION_EXTENSION_UPDATE_FOUND,
content::NotificationService::AllSources()).Wait();
+ // Temporary solution to mimic the old behavior of
+ // WindowedNotificationObserver.
+ // TODO(https://crbug.com/695073): Likely this has to be removed, and the
+ // IsIdleForTesting check at the end of this test has to be either changed to
+ // a more specific check or removed.
+ content::RunAllPendingInMessageLoop();
// Verify that the downloader is attempting to download a CRX file.
fetcher = factory.GetFetcherByID(
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/login_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698