Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2720383002: Chrome OS component updater: UpdateSeverity::LOW (Closed)

Created:
3 years, 9 months ago by ilja
Modified:
3 years, 9 months ago
Reviewers:
marcheu, oshima
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Chrome OS component updater: UpdateSeverity::LOW Use UpdateSeverity::LOW icon for Flash updates. TEST=test_that <ip> desktopui_FlashSanityCheck.download-omaha-component See black arrow in grey instead of yellow circle. BUG=688532 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2720613007 Cr-Commit-Position: refs/heads/master@{#453540} (cherry picked from commit 2d0c679aff7cac0b26ca5c3652745db3393a817b) Review-Url: https://codereview.chromium.org/2720383002 Cr-Commit-Position: refs/branch-heads/2987@{#725} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d5b7bced0df9939cde1123d61db9de5c5c169ffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/ash/system_tray_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720383002/1
3 years, 9 months ago (2017-02-28 23:06:51 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-02-28 23:06:52 UTC) #4
oshima
lgtm
3 years, 9 months ago (2017-02-28 23:10:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720383002/1
3 years, 9 months ago (2017-02-28 23:11:58 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-02-28 23:11:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720383002/1
3 years, 9 months ago (2017-02-28 23:14:19 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 23:38:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5b7bced0df9939cde1123d61db9...

Powered by Google App Engine
This is Rietveld 408576698