Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2720613007: Chrome OS component updater: UpdateSeverity::LOW (Closed)

Created:
3 years, 9 months ago by ilja
Modified:
3 years, 9 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome OS component updater: UpdateSeverity::LOW Use UpdateSeverity::LOW icon for Flash updates. TEST=test_that <ip> desktopui_FlashSanityCheck.download-omaha-component See black arrow in grey instead of yellow circle. BUG=688532 Review-Url: https://codereview.chromium.org/2720613007 Cr-Commit-Position: refs/heads/master@{#453540} Committed: https://chromium.googlesource.com/chromium/src/+/2d0c679aff7cac0b26ca5c3652745db3393a817b

Patch Set 1 #

Patch Set 2 : Update test details #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/ash/system_tray_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
ilja
We need to integrate this to M-57 to cause less surprise with users that we ...
3 years, 9 months ago (2017-02-28 05:23:00 UTC) #3
marcheu
lgtm
3 years, 9 months ago (2017-02-28 06:26:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720613007/20001
3 years, 9 months ago (2017-02-28 06:30:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/374362)
3 years, 9 months ago (2017-02-28 06:36:45 UTC) #10
oshima
lgtm
3 years, 9 months ago (2017-02-28 07:21:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720613007/20001
3 years, 9 months ago (2017-02-28 07:33:39 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 07:38:02 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2d0c679aff7cac0b26ca5c365274...

Powered by Google App Engine
This is Rietveld 408576698