Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2720293002: chromeos: Merge ash_chromeos_strings.grdp into ash_strings.grd (Closed)

Created:
3 years, 9 months ago by James Cook
Modified:
3 years, 9 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Merge ash_chromeos_strings.grdp into ash_strings.grd Ash only runs on Chrome OS, so there's no need for a separate Chrome OS-only strings file. BUG=666773 TEST=ash_unittests, run chrome and verify strings are visible Review-Url: https://codereview.chromium.org/2720293002 Cr-Commit-Position: refs/heads/master@{#453701} Committed: https://chromium.googlesource.com/chromium/src/+/087deb321baa68111033bbe9e74d1ef255606ac3

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+616 lines, -628 lines) Patch
M ash/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ash/ash_chromeos_strings.grdp View 1 chunk +0 lines, -620 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +613 lines, -4 lines 0 comments Download
M ash/common/accelerators/accelerator_table.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
James Cook
stevenjb, PTAL
3 years, 9 months ago (2017-02-28 16:14:15 UTC) #2
stevenjb
lgtm
3 years, 9 months ago (2017-02-28 20:24:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720293002/20001
3 years, 9 months ago (2017-02-28 20:31:00 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 21:09:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/087deb321baa68111033bbe9e74d...

Powered by Google App Engine
This is Rietveld 408576698