Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Issue 272025: Trim the list of signals used by debug_util::DisableOSCrashDumps() on Mac (Closed)

Created:
11 years, 2 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL, jeremy
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, pam+watch_chromium.org, John Grabowski
Visibility:
Public.

Description

Trim the list of signals used by debug_util::DisableOSCrashDumps() on Mac. The list was too long and was catching signals corresponding to Mach exceptions that Apple Crash Reporter never attempts to catch, and signals that don't even map to Mach exceptions. The default signal handlers are fine in these cases. BUG=24568 TEST=Crash reporting still disabled when appropriate (see chrome/app/chrome_dll_main.cc and the comment before DisableOSCrashDumps in ChromeMain) Specifically, with stats reporting disabled, about:crash should result in a sad tab but no silent crash report generated in ~/Library/Logs/CrashReporter Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M base/debug_util.h View 1 chunk +4 lines, -6 lines 0 comments Download
M base/debug_util_mac.cc View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
11 years, 2 months ago (2009-10-12 03:21:24 UTC) #1
TVL
lgtm (fyi - the other list i think came from testshell at one time, and ...
11 years, 2 months ago (2009-10-12 11:27:48 UTC) #2
jeremy
11 years, 2 months ago (2009-10-12 20:48:47 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698