Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: base/debug_util_mac.cc

Issue 272025: Trim the list of signals used by debug_util::DisableOSCrashDumps() on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug_util_mac.cc
===================================================================
--- base/debug_util_mac.cc (revision 28692)
+++ base/debug_util_mac.cc (working copy)
@@ -14,19 +14,18 @@
// static
void DebugUtil::DisableOSCrashDumps() {
- int signals_to_intercept[] ={SIGINT,
- SIGHUP,
- SIGTERM,
- SIGABRT,
- SIGILL,
- SIGTRAP,
- SIGEMT,
- SIGFPE,
- SIGBUS,
- SIGSEGV,
- SIGSYS,
- SIGXCPU,
- SIGXFSZ};
+ // These are the POSIX signals corresponding to the Mach exceptions that
+ // Apple Crash Reporter handles. See ux_exception() in xnu's
+ // bsd/uxkern/ux_exception.c and machine_exception() in xnu's
+ // bsd/dev/*/unix_signal.c.
+ const int signals_to_intercept[] ={
+ SIGILL, // EXC_BAD_INSTRUCTION
+ SIGTRAP, // EXC_BREAKPOINT
+ SIGFPE, // EXC_ARITHMETIC
+ SIGBUS, // EXC_BAD_ACCESS
+ SIGSEGV // EXC_BAD_ACCESS
+ };
+
// For all these signals, just wire things up so we exit immediately.
for (size_t i = 0; i < arraysize(signals_to_intercept); ++i) {
signal(signals_to_intercept[i], ExitSignalHandler);
« no previous file with comments | « base/debug_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698